Page MenuHomePhabricator
Differential D15899

Prevent users from disabling repository builtin URIs
ClosedPublic
Actions

Authored by epriestley on May 12 2016, 3:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 9:29 PM
Unknown Object (File)
Fri, Dec 13, 4:50 PM
Unknown Object (File)
Wed, Nov 27, 5:30 PM
Unknown Object (File)
Wed, Nov 20, 8:28 PM
Unknown Object (File)
Nov 16 2024, 12:53 AM
Unknown Object (File)
Nov 14 2024, 7:38 AM
Unknown Object (File)
Nov 12 2024, 8:38 AM
Unknown Object (File)
Nov 12 2024, 7:08 AM
View All Files
Subscribers
eadler

Details

Reviewers
chad
Maniphest Tasks
T10923: Diffusion API/URI Errata
Commits
rP9d196648f54f: Prevent users from disabling repository builtin URIs
Summary

Ref T10923. Currently, users can disable or enable builtin URIs, but this doesn't actually do anything.

The behavior of "disable" has changed a bit over time and might need some further refinement, but it's currently meaningless for builtin URIs. Prevent adjustment of it. If users want to hide a URI, they should set "Display: Hidden" instead.

Test Plan
  • Disabled/enabled a non-builtin URI.
  • Tried to disable a builtin URI, saw greyed out UI and got a helpful error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38292.May 12 2016, 3:29 PM
epriestley retitled this revision from to Prevent users from disabling repository builtin URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10923: Diffusion API/URI Errata.
eadler added a subscriber: eadler.May 12 2016, 4:14 PM

If this was already done will there be any repercussions?

epriestley added a comment.May 12 2016, 4:15 PM

There shouldn't be -- the database value is completely ignored and automatically adjusted to the expected value at runtime.

chad accepted this revision.May 12 2016, 7:01 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 12 2016, 7:01 PM
Closed by commit rP9d196648f54f: Prevent users from disabling repository builtin URIs (authored by epriestley, committed by epriestley). · Explain WhyMay 12 2016, 7:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
10 lines
4 lines
editor/
20 lines

Diff 38299

View Options

src/applications/diffusion/controller/DiffusionRepositoryURIDisableController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionURIEditor.php

Loading...
Phabricator · Built by Phacility