Page MenuHomePhabricator
Differential D15865

Fix some pagination/redirect issues for repositories
ClosedPublic
Actions

Authored by epriestley on May 6 2016, 7:38 PM.
Tags
None
Referenced Files
F18830532: D15865.id38217.diff
Sat, Oct 25, 7:15 AM
F18784119: D15865.id38218.diff
Mon, Oct 13, 11:53 AM
F18784104: D15865.id38217.diff
Mon, Oct 13, 11:52 AM
F18784097: D15865.id.diff
Mon, Oct 13, 11:52 AM
F18784037: D15865.diff
Mon, Oct 13, 11:44 AM
F18775123: D15865.id.diff
Fri, Oct 10, 6:00 PM
F18760156: D15865.id38218.diff
Mon, Oct 6, 8:14 AM
F18733337: D15865.id.diff
Tue, Sep 30, 10:32 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10923: Diffusion API/URI Errata
Commits
rP612a93229fa3: Fix some pagination/redirect issues for repositories
Summary

Ref T10923. Paging wasn't being applied correctly when creating new repositories after API changes.

Also, the first redirect after creation wasn't sending users to the right place.

Test Plan
  • Created a new repostiory, got redirected properly.
  • Verified that new repostiory flow has the correct fields (name, callsign, etc) and Conduit API has the correct fields (everything).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38217.May 6 2016, 7:38 PM
epriestley retitled this revision from to Fix some pagination/redirect issues for repositories.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10923: Diffusion API/URI Errata.
chad accepted this revision.May 6 2016, 7:38 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 6 2016, 7:38 PM
Closed by commit rP612a93229fa3: Fix some pagination/redirect issues for repositories (authored by epriestley, committed by epriestley). · Explain WhyMay 6 2016, 7:40 PM
This revision was automatically updated to reflect the committed changes.
Luke081515.2 mentioned this in T10923: Diffusion API/URI Errata.May 6 2016, 9:45 PM
epriestley mentioned this in T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.May 8 2016, 4:05 PM

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editengine/
11 lines

Diff 38218

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
Phabricator · Built by Phacility