Ref T9606
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T9606: "Calendar" tab on user profiles is pretty junky
- Commits
- rPde645301b57f: Adding a calendar preview panel to people profile
Open people profile for a user with events today/tomorrow, see a panel under badges panel with event list
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- profilecalendar
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 12310 Build 15565: Run Core Tests Build 15564: arc lint + arc unit
Event Timeline
Comment Actions
This looks good to me, except that in Safari, this element looks a bit weird: broken right border (should be solid, like other panels), odd spacing at the bottom:
Might just need some extra CSS rules for when it renders on a profile, or to make whatever rules are creating the weirdness only activate on the main calendar view?
| src/applications/people/controller/PhabricatorPeopleProfileViewController.php | ||
|---|---|---|
| 202–204 | Maybe just use withIsCancelled(false) on the query? | |
Comment Actions
but this means that the week panel in day view is going to be max width. Personally, I think it looks okay, but maybe there's a reason not to do this?
This fixed the border on the panel:
but this means that the week panel in day view is going to be max width. Personally, I think it looks okay, but maybe there's a reason not to do this?
Comment Actions
Query for events that were not cancelled instead of filtering out cancelled events later.
Comment Actions
Feel free to check in something somewhat decent looking and I can come through and clean up / rework if needed.
Comment Actions
Yeah, this is good. It doesn't look "obviously broken" to me anymore, and the view in Calendar a lot less weird looking to me, too.