Page MenuHomePhabricator
Differential D15846

Generate syntax highlighting CSS from a reusable map
ClosedPublic
Actions

Authored by epriestley on May 5 2016, 1:28 AM.
Tags
None
Referenced Files
F18803618: D15846.diff
Sat, Oct 18, 2:02 AM
F18756220: D15846.diff
Sun, Oct 5, 10:12 AM
F18753578: D15846.id.diff
Sat, Oct 4, 7:30 PM
F18748275: D15846.diff
Fri, Oct 3, 8:21 PM
F18742351: D15846.id38174.diff
Thu, Oct 2, 6:50 PM
F18741843: D15846.id38174.diff
Thu, Oct 2, 4:20 PM
F18727180: D15846.diff
Tue, Sep 30, 7:42 AM
F18680308: D15846.id38183.diff
Fri, Sep 26, 2:32 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments
Commits
rP01289f3f486a: Generate syntax highlighting CSS from a reusable map
Summary

Ref T9790. This prepares the syntax color rules to be reused in mail.

This goes about halfway toward T5701 by sort-of supporting different styles but not really.

Test Plan
  • Ran bin/celerity syntax to regenerate syntax map.
  • Viewed some highlighted code, didn't see any differences.

Diff Detail

Repository
rP Phabricator
Branch
syntax2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12050
Build 15174: Run Core Tests
Build 15173: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38174.May 5 2016, 1:28 AM
epriestley retitled this revision from to Generate syntax highlighting CSS from a reusable map.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
Herald edited edge metadata. · View Herald TranscriptMay 5 2016, 1:28 AM
chad accepted this revision.May 5 2016, 1:32 AM
chad edited edge metadata.
This revision is now accepted and ready to land.May 5 2016, 1:32 AM
Closed by commit rP01289f3f486a: Generate syntax highlighting CSS from a reusable map (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2016, 9:50 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10694: Improve behavior of context for inline comments in mail.May 5 2016, 6:55 PM
chad added a comment.Jul 18 2017, 10:59 PM

hmmm

chad added a comment.Jul 18 2017, 11:01 PM

this is cramping my style

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
1 line
src/
6 lines
applications/
celerity/
management/
67 lines
infrastructure/
syntax/
76 lines
30 lines
webroot/
rsrc/
css/
core/
105 lines
syntax/
150 lines

Diff 38174

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/celerity/management/CelerityManagementSyntaxWorkflow.php

Loading...
View Options

src/infrastructure/syntax/PhabricatorDefaultSyntaxStyle.php

Loading...
View Options

src/infrastructure/syntax/PhabricatorSyntaxStyle.php

Loading...
View Options

webroot/rsrc/css/core/syntax.css

Loading...
View Options

webroot/rsrc/css/syntax/syntax-default.css

Loading...
Phabricator · Built by Phacility