Remove "repository.create" Conduit API method
ClosedPublic
Actions

Authored by epriestley on May 3 2016, 8:07 PM.

Details

Reviewers

chad

Maniphest Tasks

T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API

Commits

rPb8b700c179db: Remove "repository.create" Conduit API method

Summary

Ref T10748. This has had many problems for a long time, can't create hosted repositories, can't create cluster repositories, etc. It is obsoleted by diffusion.repository.edit. Remove it.

(Right now diffusion.repository.edit isn't a strict replacement, but it will be as soon as the URI stuff cuts over.)

Test Plan

Grepped for repository.create.

Diff Detail

Repository

rP Phabricator

Branch

repo25

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 12026
Build 15135: Run Core Tests
Build 15134: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1 ms	ConduitAPIMethodTestCase::Unknown Unit Message ("") EXCEPTION (PhutilBootloaderException): Include of '/core/data/drydock/workingcopy-71/repo/phabricator/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php' failed! #0 /core/data/drydock/workingcopy-71/repo/libphutil/src/symbols/PhutilSymbolLoader.php(381): PhutilBootloader->loadLibrarySource('phabricator', 'applications/re...') #1 /core/data/drydock/workingcopy-71/repo/libphutil/src/symbols/PhutilSymbolLoader.php(256): PhutilSymbolLoader->loadSymbol(Array)
	0 ms	ConduitCallTestCase::Unknown Unit Message ("") EXCEPTION (PhutilBootloaderException): Include of '/core/data/drydock/workingcopy-71/repo/phabricator/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php' failed! #0 /core/data/drydock/workingcopy-71/repo/libphutil/src/symbols/PhutilSymbolLoader.php(381): PhutilBootloader->loadLibrarySource('phabricator', 'applications/re...') #1 /core/data/drydock/workingcopy-71/repo/libphutil/src/symbols/PhutilSymbolLoader.php(256): PhutilSymbolLoader->loadSymbol(Array)
	0 ms	ConduitCallTestCase::Unknown Unit Message ("") EXCEPTION (PhutilBootloaderException): Include of '/core/data/drydock/workingcopy-71/repo/phabricator/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php' failed! #0 /core/data/drydock/workingcopy-71/repo/libphutil/src/symbols/PhutilSymbolLoader.php(381): PhutilBootloader->loadLibrarySource('phabricator', 'applications/re...') #1 /core/data/drydock/workingcopy-71/repo/libphutil/src/symbols/PhutilSymbolLoader.php(256): PhutilSymbolLoader->loadSymbol(Array)
	17 ms	HarbormasterAutotargetsTestCase::Unknown Unit Message ("") EXCEPTION (PhutilBootloaderException): Include of '/core/data/drydock/workingcopy-71/repo/phabricator/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php' failed! #0 /core/data/drydock/workingcopy-71/repo/libphutil/src/symbols/PhutilSymbolLoader.php(381): PhutilBootloader->loadLibrarySource('phabricator', 'applications/re...') #1 /core/data/drydock/workingcopy-71/repo/libphutil/src/symbols/PhutilSymbolLoader.php(256): PhutilSymbolLoader->loadSymbol(Array)
	245 ms	PhabricatorChangeParserTestCase::Unknown Unit Message ("") EXCEPTION (PhutilBootloaderException): Include of '/core/data/drydock/workingcopy-71/repo/phabricator/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php' failed! #0 /core/data/drydock/workingcopy-71/repo/libphutil/src/symbols/PhutilSymbolLoader.php(381): PhutilBootloader->loadLibrarySource('phabricator', 'applications/re...') #1 /core/data/drydock/workingcopy-71/repo/libphutil/src/symbols/PhutilSymbolLoader.php(256): PhutilSymbolLoader->loadSymbol(Array)
		View Full Test Results (9 Failed · 307 Passed)