Page MenuHomePhabricator

Guarantee repositories have unique local paths
ClosedPublic

Authored by epriestley on May 3 2016, 7:40 PM.
Tags
None
Referenced Files
F15484055: D15837.diff
Wed, Apr 9, 3:56 PM
F15462978: D15837.id38149.diff
Tue, Apr 1, 7:27 PM
F15458977: D15837.id38165.diff
Mon, Mar 31, 8:52 AM
F15437776: D15837.id.diff
Tue, Mar 25, 9:23 PM
F15434804: D15837.diff
Tue, Mar 25, 5:32 AM
F15430354: D15837.diff
Mon, Mar 24, 7:15 AM
F15429296: D15837.id38149.diff
Mon, Mar 24, 1:34 AM
F15409600: D15837.id38149.diff
Wed, Mar 19, 4:45 AM
Subscribers
None

Details

Summary

Ref T4039. Long ago these were more freely editable and there were some security concerns around creating a repository, then setting its local path to point somewhere it shouldn't.

Local paths are no longer editable so there's no real reason we need to provide a uniqueness guarantee anymore, but you could still make a mistake with bin/repository move-paths by accident, and it's a little cleaner to pull them out into their own column with a key.

(We still don't -- and, largely can't -- guarantee that two paths aren't equivalent since one might be symlinked to the other, or symlinked only on some hosts, or whatever, but the primary value here is as a sanity check that you aren't goofing things up and pointing a bunch of repositories at the same working copy by mistake.)

Test Plan
  • Ran migrations.
  • Grepped for local-path.
  • Listed and moved paths with bin/repository.
  • Created a new repository, verified its local path populated correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable