Page MenuHomePhabricator

Guarantee repositories have unique local paths
ClosedPublic

Authored by epriestley on May 3 2016, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 1:07 PM
Unknown Object (File)
Thu, Dec 12, 1:02 AM
Unknown Object (File)
Sun, Dec 8, 5:40 AM
Unknown Object (File)
Wed, Dec 4, 5:31 AM
Unknown Object (File)
Sat, Nov 30, 9:48 AM
Unknown Object (File)
Tue, Nov 26, 2:58 PM
Unknown Object (File)
Tue, Nov 26, 1:48 PM
Unknown Object (File)
Tue, Nov 26, 1:48 PM
Subscribers
None

Details

Summary

Ref T4039. Long ago these were more freely editable and there were some security concerns around creating a repository, then setting its local path to point somewhere it shouldn't.

Local paths are no longer editable so there's no real reason we need to provide a uniqueness guarantee anymore, but you could still make a mistake with bin/repository move-paths by accident, and it's a little cleaner to pull them out into their own column with a key.

(We still don't -- and, largely can't -- guarantee that two paths aren't equivalent since one might be symlinked to the other, or symlinked only on some hosts, or whatever, but the primary value here is as a sanity check that you aren't goofing things up and pointing a bunch of repositories at the same working copy by mistake.)

Test Plan
  • Ran migrations.
  • Grepped for local-path.
  • Listed and moved paths with bin/repository.
  • Created a new repository, verified its local path populated correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable