Paths

Table of Contentst

Differential D15829

Fill in new URI credential edit web UI interfaces
ClosedPublic
Actions

Authored by epriestley on May 1 2016, 4:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 19, 4:36 PM

	Unknown Object (File)
	Thu, Apr 11, 7:25 AM

	Unknown Object (File)
	Mon, Apr 8, 5:24 AM

	Unknown Object (File)
	Mon, Apr 1, 3:28 AM

	Unknown Object (File)
	Mon, Apr 1, 2:14 AM

	Unknown Object (File)
	Thu, Mar 28, 11:15 PM

	Unknown Object (File)
	Mar 13 2024, 6:53 PM

	Unknown Object (File)
	Mar 8 2024, 10:51 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T7221: External git repository SSH credentials are not optional
T10241: Modifying an externally-hosted repository's URL/path can unintentionally change the credentials
T10366: General support for multiple URIs for a repository
T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API

Commits

rP99718b61d8f3: Fill in new URI credential edit web UI interfaces

Summary

Ref T10748. Ref T10366. Allows users to set credential for new URIs.

Ref T7221. Our handling of the "git://" protocol is currently incorrect. This protocol is not authenticated, but is considered an SSH protocol. In the new UI, it is considered an anonymous/unauthenticated protocol instead.
Ref T10241. This fixes the PassphraseCredentialControl so it doesn't silently edit the value if the current value is not visible to you and/or not valid.

Test Plan

Performed a whole lot of credential edits, removals, and adjustments. I'll give this additional vetting before cutting over to it.

Screen Shot 2016-05-01 at 9.34.23 AM.png (1×1 px, 170 KB)

Diff Detail

Repository

Branch

repo20

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12008
Build 15108: Run Core Tests
Build 15107: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38132.May 1 2016, 4:38 PM

epriestley retitled this revision from to Fill in new URI credential edit web UI interfaces.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API, T10366: General support for multiple URIs for a repository, T10241: Modifying an externally-hosted repository's URL/path can unintentionally change the credentials, T7221: External git repository SSH credentials are not optional.

epriestley mentioned this in T7221: External git repository SSH credentials are not optional.May 1 2016, 4:40 PM

epriestley mentioned this in T10241: Modifying an externally-hosted repository's URL/path can unintentionally change the credentials.

chad accepted this revision.May 1 2016, 5:44 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 1 2016, 5:44 PM

chad added inline comments.May 1 2016, 5:47 PM

src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php
194	maybe fa-ban

Closed by commit rP99718b61d8f3: Fill in new URI credential edit web UI interfaces (authored by epriestley, committed by epriestley). · Explain WhyMay 2 2016, 11:26 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.May 5 2016, 12:15 AM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

diffusion/

application/

PhabricatorDiffusionApplication.php

2 lines

controller/

DiffusionMirrorEditController.php

2 lines

DiffusionRepositoryCreateController.php

1 line

DiffusionRepositoryURICredentialController.php

159 lines

DiffusionRepositoryURIViewController.php

120 lines

editor/

DiffusionURIEditEngine.php

13 lines

DiffusionURIEditor.php

40 lines

protocol/

DiffusionCommandEngine.php

66 lines

passphrase/

view/

PassphraseCredentialControl.php

42 lines

repository/

storage/

PhabricatorRepositoryURI.php

89 lines

PhabricatorRepositoryURITransaction.php

38 lines

infrastructure/

customfield/

standard/

PhabricatorStandardCustomFieldCredential.php

1 line

Diff 38132

src/__phutil_library_map__.php

Loading...

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...

src/applications/diffusion/controller/DiffusionMirrorEditController.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryURICredentialController.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php

Loading...

src/applications/diffusion/editor/DiffusionURIEditEngine.php

Loading...

src/applications/diffusion/editor/DiffusionURIEditor.php

Loading...

src/applications/diffusion/protocol/DiffusionCommandEngine.php

Loading...

src/applications/passphrase/view/PassphraseCredentialControl.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryURITransaction.php

Loading...

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php

Loading...