Page MenuHomePhabricator

Fill in new URI credential edit web UI interfaces
ClosedPublic

Authored by epriestley on May 1 2016, 4:38 PM.

Details

Summary

Ref T10748. Ref T10366. Allows users to set credential for new URIs.

  • Ref T7221. Our handling of the "git://" protocol is currently incorrect. This protocol is not authenticated, but is considered an SSH protocol. In the new UI, it is considered an anonymous/unauthenticated protocol instead.
  • Ref T10241. This fixes the PassphraseCredentialControl so it doesn't silently edit the value if the current value is not visible to you and/or not valid.
Test Plan

Performed a whole lot of credential edits, removals, and adjustments. I'll give this additional vetting before cutting over to it.

Screen Shot 2016-05-01 at 9.34.23 AM.png (1×1 px, 170 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.May 1 2016, 5:44 PM
src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php
194

maybe fa-ban

This revision was automatically updated to reflect the committed changes.