Page MenuHomePhabricator
Differential D15808

Port Repository "Symbols" to Manage/Panel UI
ClosedPublic
Actions

Authored by epriestley on Apr 27 2016, 5:34 PM.
Tags
None
Referenced Files
F15701465: D15808.diff
Wed, May 28, 7:09 PM
F15692137: D15808.id38082.diff
Wed, May 28, 4:39 AM
F15691208: D15808.id38082.diff
Wed, May 28, 2:33 AM
F15688841: D15808.diff
Tue, May 27, 10:42 PM
Unknown Object (File)
Tue, May 27, 1:13 PM
Unknown Object (File)
Mon, May 26, 11:25 PM
Unknown Object (File)
Thu, May 8, 10:04 PM
Unknown Object (File)
Wed, May 7, 2:51 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API
Commits
rP8f81930b5d54: Port Repository "Symbols" to Manage/Panel UI
Summary

Ref T10748. Port this, add EditEngine support, add some type validation to the transaction.

Test Plan
  • Edited via EditEngine.
  • Edited via Conduit.
  • Viewed via Management UI.

Diff Detail

Repository
rP Phabricator
Branch
repo6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11956
Build 15034: Run Core Tests
Build 15033: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38082.Apr 27 2016, 5:34 PM
epriestley retitled this revision from to Port Repository "Symbols" to Manage/Panel UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
chad accepted this revision.Apr 27 2016, 6:01 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 27 2016, 6:01 PM
Closed by commit rP8f81930b5d54: Port Repository "Symbols" to Manage/Panel UI (authored by epriestley, committed by epriestley). · Explain WhyApr 28 2016, 12:35 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.Apr 30 2016, 12:43 AM

Revision Contents
Changeset List

Diff 38082

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryHistoryManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositorySymbolsManagementPanel.php

Loading...
View Options

src/applications/repository/editor/PhabricatorRepositoryEditor.php

Loading...
Phabricator · Built by Phacility