Paths

Table of Contentst

Differential D15793

Fix two issues with Remarkup in Pholio
ClosedPublic
Actions

Authored by epriestley on Apr 25 2016, 12:12 PM.

Details

Reviewers

chad

Maniphest Tasks

T10865: Remarkup is not rendered in Pholio Application

Commits

rP1c0980a26a86: Fix two issues with Remarkup in Pholio

Summary

Fixes T10865.

Mock descriptions did not markup.
Image descriptions did not get a proper container <div />.

Test Plan

Created a mock with remarkup in the mock description and in an image description.
Viewed mock detail.
Saw list styles render properly in both mock description and image description.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38041.Apr 25 2016, 12:12 PM

epriestley retitled this revision from to Fix two issues with Remarkup in Pholio.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10865: Remarkup is not rendered in Pholio Application.

chad accepted this revision.Apr 25 2016, 1:48 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 25 2016, 1:48 PM

Closed by commit rP1c0980a26a86: Fix two issues with Remarkup in Pholio (authored by epriestley, committed by epriestley). · Explain WhyApr 25 2016, 3:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

controller/

PholioMockViewController.php

5 lines

view/

PholioMockImagesView.php

12 lines

Diff 38045

View Options

src/applications/pholio/controller/PholioMockViewController.php