Paths

Table of Contentst

Differential D15790

Move all cluster locking logic to a separate class
ClosedPublic
Actions

Authored by epriestley on Apr 24 2016, 4:07 PM.

Tags

None

Referenced Files

	F16417346: D15790.diff
	Mon, Jun 16, 7:59 AM

	Unknown Object (File)
	Tue, May 27, 11:05 AM

	Unknown Object (File)
	May 9 2025, 9:25 AM

	Unknown Object (File)
	May 7 2025, 7:55 PM

	Unknown Object (File)
	Apr 26 2025, 7:26 AM

	Unknown Object (File)
	Apr 24 2025, 3:23 PM

	Unknown Object (File)
	Apr 13 2025, 10:49 PM

	Unknown Object (File)
	Apr 8 2025, 11:28 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10860: After an inconsistent cluster repository write, consider just ignoring the lock

Commits

rPdc75b4bd0602: Move all cluster locking logic to a separate class

Summary

Ref T10860. This doesn't change anything, it just separates all this stuff out of PhabricatorRepository since I'm planning to add a bit more state to it and it's already pretty big and fairly separable.

Test Plan

Pulled, pushed, browsed Diffusion.

Diff Detail

Repository

Branch

db1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php:95	XHP16	TODO Comment
Advice	src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php:213	XHP16	TODO Comment
Advice	src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php:315	XHP16	TODO Comment
Advice	src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php:320	XHP16	TODO Comment
Advice	src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php:358	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 11911
Build 14966: Run Core Tests
Build 14965: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38037.Apr 24 2016, 4:07 PM

epriestley retitled this revision from to Move all cluster locking logic to a separate class.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10860: After an inconsistent cluster repository write, consider just ignoring the lock.

epriestley mentioned this in T10860: After an inconsistent cluster repository write, consider just ignoring the lock.Apr 24 2016, 6:39 PM

chad accepted this revision.Apr 25 2016, 2:15 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 25 2016, 2:15 PM

Closed by commit rPdc75b4bd0602: Move all cluster locking logic to a separate class (authored by epriestley, committed by epriestley). · Explain WhyApr 25 2016, 6:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 26 2016, 3:18 AM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

diffusion/

conduit/

DiffusionQueryCommitsConduitAPIMethod.php

10 lines

DiffusionQueryConduitAPIMethod.php

8 lines

controller/

DiffusionServeController.php

10 lines

protocol/

DiffusionRepositoryClusterEngine.php

435 lines

ssh/

DiffusionGitReceivePackSSHWorkflow.php

11 lines

DiffusionGitUploadPackSSHWorkflow.php

6 lines

repository/

editor/

PhabricatorRepositoryEditor.php

5 lines

engine/

PhabricatorRepositoryPullEngine.php

6 lines

storage/

PhabricatorRepository.php

379 lines

Diff 38037

src/__phutil_library_map__.php

Loading...

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php

Loading...

src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php

Loading...

src/applications/diffusion/controller/DiffusionServeController.php

Loading...

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

Loading...

src/applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php

Loading...

src/applications/diffusion/ssh/DiffusionGitUploadPackSSHWorkflow.php

Loading...

src/applications/repository/editor/PhabricatorRepositoryEditor.php

Loading...

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...