Page MenuHomePhabricator
Differential D15790

Move all cluster locking logic to a separate class
ClosedPublic
Actions

Authored by epriestley on Apr 24 2016, 4:07 PM.
Tags
None
Referenced Files
F19046048: D15790.id.diff
Thu, Nov 27, 9:29 AM
F19034503: D15790.diff
Tue, Nov 25, 2:20 PM
F19032288: D15790.id38050.diff
Tue, Nov 25, 5:50 AM
F19030969: D15790.diff
Mon, Nov 24, 10:58 PM
F19015658: D15790.diff
Sun, Nov 23, 1:07 AM
F18907590: D15790.id38037.diff
Nov 9 2025, 12:07 AM
F18907588: D15790.id.diff
Nov 9 2025, 12:07 AM
F18905983: D15790.id38037.diff
Nov 8 2025, 4:25 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10860: After an inconsistent cluster repository write, consider just ignoring the lock
Commits
rPdc75b4bd0602: Move all cluster locking logic to a separate class
Summary

Ref T10860. This doesn't change anything, it just separates all this stuff out of PhabricatorRepository since I'm planning to add a bit more state to it and it's already pretty big and fairly separable.

Test Plan

Pulled, pushed, browsed Diffusion.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38037.Apr 24 2016, 4:07 PM
epriestley retitled this revision from to Move all cluster locking logic to a separate class.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10860: After an inconsistent cluster repository write, consider just ignoring the lock.
epriestley mentioned this in T10860: After an inconsistent cluster repository write, consider just ignoring the lock.Apr 24 2016, 6:39 PM
chad accepted this revision.Apr 25 2016, 2:15 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 25 2016, 2:15 PM
Closed by commit rPdc75b4bd0602: Move all cluster locking logic to a separate class (authored by epriestley, committed by epriestley). · Explain WhyApr 25 2016, 6:20 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 26 2016, 3:18 AM

Revision Contents
Changeset List

Diff 38050

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionGitUploadPackSSHWorkflow.php

Loading...
View Options

src/applications/repository/editor/PhabricatorRepositoryEditor.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility