Page MenuHomePhabricator

Improve robustness of cluster version bookkeeping
ClosedPublic

Authored by epriestley on Apr 18 2016, 3:20 PM.
Tags
None
Referenced Files
F15489409: D15747.id37949.diff
Fri, Apr 11, 8:50 AM
F15488670: D15747.id37947.diff
Fri, Apr 11, 1:13 AM
F15472532: D15747.id.diff
Sat, Apr 5, 2:21 PM
F15470145: D15747.diff
Fri, Apr 4, 8:38 PM
F15467504: D15747.id37949.diff
Thu, Apr 3, 3:41 PM
F15448336: D15747.id37949.diff
Fri, Mar 28, 4:15 AM
F15436919: D15747.id37949.diff
Mar 25 2025, 4:46 PM
F15428869: D15747.diff
Mar 23 2025, 10:53 PM
Subscribers
None

Details

Summary

Ref T4292. Small fixes:

  • There was a bug with the first write, where we'd write 1 but expect 0. Fix this.
  • Narrow the window where we hold the isWriting lock: we don't need to wait for the client to finish.
  • Release the lock even if something throws.
  • Use a more useful variable name.
Test Plan
  • Made new writes to a fresh cluster repository.
  • Made sequential writes.
  • Made concurrent writes.
  • Made good writes and bad writes.

Diff Detail

Repository
rP Phabricator
Branch
rlock1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11820
Build 14828: Run Core Tests
Build 14827: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve robustness of cluster version bookkeeping.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 18 2016, 3:36 PM
This revision was automatically updated to reflect the committed changes.