Page MenuHomePhabricator

Improve robustness of cluster version bookkeeping
ClosedPublic

Authored by epriestley on Apr 18 2016, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 2:34 AM
Unknown Object (File)
Tue, Mar 26, 6:01 AM
Unknown Object (File)
Sat, Mar 16, 3:11 PM
Unknown Object (File)
Jan 27 2024, 6:02 AM
Unknown Object (File)
Jan 17 2024, 12:39 AM
Unknown Object (File)
Dec 30 2023, 11:57 PM
Unknown Object (File)
Dec 27 2023, 6:48 AM
Unknown Object (File)
Dec 21 2023, 1:29 PM
Subscribers
None

Details

Summary

Ref T4292. Small fixes:

  • There was a bug with the first write, where we'd write 1 but expect 0. Fix this.
  • Narrow the window where we hold the isWriting lock: we don't need to wait for the client to finish.
  • Release the lock even if something throws.
  • Use a more useful variable name.
Test Plan
  • Made new writes to a fresh cluster repository.
  • Made sequential writes.
  • Made concurrent writes.
  • Made good writes and bad writes.

Diff Detail

Repository
rP Phabricator
Branch
rlock1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11820
Build 14828: Run Core Tests
Build 14827: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve robustness of cluster version bookkeeping.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 18 2016, 3:36 PM
This revision was automatically updated to reflect the committed changes.