Page MenuHomePhabricator

Improve robustness of cluster version bookkeeping
ClosedPublic

Authored by epriestley on Apr 18 2016, 3:20 PM.
Tags
None
Referenced Files
F11031819: D15747.id.diff
Sun, Aug 14, 3:33 AM
F11031285: D15747.diff
Sat, Aug 13, 11:19 PM
Unknown Object (File)
Sat, Aug 13, 5:14 PM
Unknown Object (File)
Mon, Aug 8, 11:19 PM
Unknown Object (File)
Mon, Aug 8, 11:19 PM
Unknown Object (File)
Mon, Aug 8, 6:07 PM
Unknown Object (File)
Mon, Aug 8, 6:07 PM
Unknown Object (File)
Sun, Jul 31, 3:20 AM
Subscribers
None

Details

Summary

Ref T4292. Small fixes:

  • There was a bug with the first write, where we'd write 1 but expect 0. Fix this.
  • Narrow the window where we hold the isWriting lock: we don't need to wait for the client to finish.
  • Release the lock even if something throws.
  • Use a more useful variable name.
Test Plan
  • Made new writes to a fresh cluster repository.
  • Made sequential writes.
  • Made concurrent writes.
  • Made good writes and bad writes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve robustness of cluster version bookkeeping.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 18 2016, 3:36 PM
This revision was automatically updated to reflect the committed changes.