Page MenuHomePhabricator

Fail explicitly instead of continuing with a warning if "phd.user" is misconfigured
ClosedPublic

Authored by epriestley on Apr 15 2016, 8:53 PM.
Tags
None
Referenced Files
F17716903: D15726.diff
Thu, Jul 17, 8:06 PM
Unknown Object (File)
Sat, Jun 28, 10:25 AM
Unknown Object (File)
Jun 19 2025, 11:43 PM
Unknown Object (File)
Jun 19 2025, 7:22 AM
Unknown Object (File)
Jun 17 2025, 1:43 PM
Unknown Object (File)
Jun 16 2025, 5:09 PM
Unknown Object (File)
May 25 2025, 11:54 PM
Unknown Object (File)
May 9 2025, 1:51 PM
Subscribers

Details

Summary

Fixes T6806. We haven't seen users having issues with phd.user in a very long time.

Test Plan
  • Configured daemons to run as notepriestley, got a well-explained exception.
  • Configured daemons to run as epriestley, got a clean start.
  • Configured daemons with phd.user=null, got a clean start.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fail explicitly instead of continuing with a warning if "phd.user" is misconfigured.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
areitz added a reviewer: areitz.
areitz added a subscriber: areitz.

LGTM, I think this is the right thing to do.

This revision is now accepted and ready to land.Apr 15 2016, 9:06 PM
epriestley edited edge metadata.
  • Print slightly more information in the exception message.
Usage Exception: Daemons are configured to run as user "notepriestley" in configuration option `phd.user`, but the current user is "epriestley" and `phd` was unable to switch to the correct user with `sudo`. Command output:

Command failed with error #1!
COMMAND
exec sudo -En -u 'notepriestley' -- ./phd-daemon '-l' 'local'

STDOUT
(empty)

STDERR
sudo: unknown user: notepriestley
This revision was automatically updated to reflect the committed changes.