Fixes T9296
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T9296: Default "one hour jump" logic not formatted correctly
- Commits
- rP42a877622859: Time controls should format end date value correctly (not 5:0 PM)
Create an event, change start time to 3PM, end value should update to 4:00 PM, not 4:0 PM
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendarendtimeformat
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 11762 Build 14739: Run Core Tests Build 14738: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 175 ms | PhabricatorCelerityTestCase::Unknown Unit Message (" ") Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it.
ACTUAL VALUE
| |
| 0 ms | AlmanacNamesTestCase::Unknown Unit Message (" ") 30 assertions passed. | |
| 0 ms | AlmanacServiceTypeTestCase::Unknown Unit Message (" ") 1 assertion passed. | |
| 0 ms | AphrontHTTPSinkTestCase::Unknown Unit Message (" ") 6 assertions passed. | |
| 0 ms | AphrontHTTPSinkTestCase::Unknown Unit Message (" ") 2 assertions passed. | |
| View Full Test Results (1 Failed · 314 Passed) |
Event Timeline
Comment Actions
Run bin/celerity map to clear that test issue.
| webroot/rsrc/js/core/behavior-time-typeahead.js | ||
|---|---|---|
| 139 | You shouldn't need the end_minutes === 0 part I think since 0 < 9? | |
| webroot/rsrc/js/core/behavior-time-typeahead.js | ||
|---|---|---|
| 139 | Haha yeah I got a little too excited about finding the problem | |