Paths

Table of Contentst

Differential D15724

Improve daemon console for daemons on multiple hosts
ClosedPublic
Actions

Authored by epriestley on Apr 15 2016, 7:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 16, 6:41 AM

	Unknown Object (File)
	Sun, Feb 9, 1:19 AM

	Unknown Object (File)
	Fri, Feb 7, 12:56 AM

	Unknown Object (File)
	Wed, Jan 29, 12:57 PM

	Unknown Object (File)
	Tue, Jan 28, 4:51 AM

	Unknown Object (File)
	Tue, Jan 28, 1:16 AM

	Unknown Object (File)
	Fri, Jan 24, 1:13 PM

	Unknown Object (File)
	Tue, Jan 21, 11:00 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T7307: Daemons UI is confusing when you aren't an administrator
T10756: Make daemons work correctly no matter where they are or how many copies are running

Commits

rPd9dd4d427d0b: Improve daemon console for daemons on multiple hosts

Summary

Ref T10756. This:

Fixes T7307. This UI is now admin-only.
Makes the main "running daemons" table more useful for multi-host setups (show where daemons are running).
Removes logs from the web UI: these are sometimes vaguely sensitive and shouldn't be visible. The UI tells you how to get them with bin/phd log.
Minor modernization.

Test Plan

As a non-admin, viewed daemons (access error) and bulk jobs (worked great).
Browsed bulk job pages.
Ran a bulk job.
Viewed daemon console.
Viewed task detail / daemon detail / daemon list pages.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37891.Apr 15 2016, 7:07 PM

epriestley retitled this revision from to Improve daemon console for daemons on multiple hosts.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10756: Make daemons work correctly no matter where they are or how many copies are running, T7307: Daemons UI is confusing when you aren't an administrator.

chad accepted this revision.Apr 15 2016, 7:17 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 15 2016, 7:17 PM

Closed by commit rPd9dd4d427d0b: Improve daemon console for daemons on multiple hosts (authored by epriestley, committed by epriestley). · Explain WhyApr 15 2016, 7:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 16 2016, 12:27 AM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

8 lines

applications/

daemon/

controller/

PhabricatorDaemonBulkJobController.php

25 lines

PhabricatorDaemonBulkJobListController.php

27 lines

PhabricatorDaemonBulkJobMonitorController.php

6 lines

PhabricatorDaemonBulkJobViewController.php

7 lines

PhabricatorDaemonConsoleController.php

13 lines

PhabricatorDaemonController.php

7 lines

PhabricatorDaemonLogListController.php

10 lines

PhabricatorDaemonLogViewController.php

16 lines

view/

PhabricatorDaemonLogListView.php

120 lines

Diff 37896

src/__phutil_library_map__.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonBulkJobController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonBulkJobListController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonBulkJobMonitorController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonBulkJobViewController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonLogListController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonLogViewController.php

Loading...

src/applications/daemon/view/PhabricatorDaemonLogListView.php

Loading...