Paths

Table of Contentst

Differential D15724

Improve daemon console for daemons on multiple hosts
ClosedPublic
Actions

Authored by epriestley on Apr 15 2016, 7:07 PM.

Tags

None

Referenced Files

	F18405024: D15724.diff
	Fri, Aug 29, 11:00 PM

	F18292838: D15724.id37891.diff
	Sat, Aug 23, 12:32 PM

	F17965738: D15724.id.diff
	Aug 1 2025, 11:41 AM

	F17950090: D15724.diff
	Aug 1 2025, 12:07 AM

	F17947034: D15724.diff
	Jul 31 2025, 3:36 PM

	Unknown Object (File)
	Jun 30 2025, 11:19 PM

	Unknown Object (File)
	May 29 2025, 11:25 AM

	Unknown Object (File)
	May 27 2025, 11:02 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T7307: Daemons UI is confusing when you aren't an administrator
T10756: Make daemons work correctly no matter where they are or how many copies are running

Commits

rPd9dd4d427d0b: Improve daemon console for daemons on multiple hosts

Summary

Ref T10756. This:

Fixes T7307. This UI is now admin-only.
Makes the main "running daemons" table more useful for multi-host setups (show where daemons are running).
Removes logs from the web UI: these are sometimes vaguely sensitive and shouldn't be visible. The UI tells you how to get them with bin/phd log.
Minor modernization.

Test Plan

As a non-admin, viewed daemons (access error) and bulk jobs (worked great).
Browsed bulk job pages.
Ran a bulk job.
Viewed daemon console.
Viewed task detail / daemon detail / daemon list pages.

Diff Detail

Repository

Branch

daemon3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11760
Build 14735: Run Core Tests
Build 14734: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37891.Apr 15 2016, 7:07 PM

epriestley retitled this revision from to Improve daemon console for daemons on multiple hosts.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10756: Make daemons work correctly no matter where they are or how many copies are running, T7307: Daemons UI is confusing when you aren't an administrator.

chad accepted this revision.Apr 15 2016, 7:17 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 15 2016, 7:17 PM

Closed by commit rPd9dd4d427d0b: Improve daemon console for daemons on multiple hosts (authored by epriestley, committed by epriestley). · Explain WhyApr 15 2016, 7:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 16 2016, 12:27 AM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

8 lines

applications/

daemon/

controller/

PhabricatorDaemonBulkJobController.php

25 lines

PhabricatorDaemonBulkJobListController.php

27 lines

PhabricatorDaemonBulkJobMonitorController.php

6 lines

PhabricatorDaemonBulkJobViewController.php

7 lines

PhabricatorDaemonConsoleController.php

13 lines

PhabricatorDaemonController.php

7 lines

PhabricatorDaemonLogListController.php

10 lines

PhabricatorDaemonLogViewController.php

16 lines

view/

PhabricatorDaemonLogListView.php

120 lines

Diff 37891

src/__phutil_library_map__.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonBulkJobController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonBulkJobListController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonBulkJobMonitorController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonBulkJobViewController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonLogListController.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonLogViewController.php

Loading...

src/applications/daemon/view/PhabricatorDaemonLogListView.php

Loading...