Page MenuHomePhabricator

Add a "memory.hint" parameter to Aphlict
ClosedPublic

Authored by epriestley on Apr 15 2016, 1:45 PM.
Tags
None
Referenced Files
F14062712: D15720.diff
Mon, Nov 18, 1:46 PM
F14046933: D15720.diff
Thu, Nov 14, 12:45 AM
F14036450: D15720.diff
Sun, Nov 10, 10:17 AM
F14021283: D15720.diff
Wed, Nov 6, 6:57 AM
F14015519: D15720.id37879.diff
Sun, Nov 3, 8:10 PM
F13987817: D15720.diff
Mon, Oct 21, 11:28 AM
F13979990: D15720.id.diff
Oct 19 2024, 7:46 AM
F13957871: D15720.id37881.diff
Oct 14 2024, 11:47 AM
Subscribers
None

Details

Summary

Ref T10696. By default, node uses 1.5GB, which is enormous overkill for this service and can crowd out other services if it's running next to things like a database on the same host.

Provide a configuration option to adjust it via --max-old-space-size and default to 256MB. It only seems to need about 30M locally, so this should be plenty of headroom.

Test Plan

Ran bin/aphlict debug, things seemed OK.

It takes a long time (days?) to grow to 1.5GB so I can't easily test this locally without a lot of work, but I'll keep an eye on it in production.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a "memory.hint" parameter to Aphlict.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 15 2016, 2:12 PM
This revision was automatically updated to reflect the committed changes.