Page MenuHomePhabricator

Add a "memory.hint" parameter to Aphlict
ClosedPublic

Authored by epriestley on Apr 15 2016, 1:45 PM.
Tags
None
Referenced Files
F14359551: D15720.diff
Fri, Dec 20, 9:31 AM
Unknown Object (File)
Wed, Dec 18, 11:58 AM
Unknown Object (File)
Thu, Dec 12, 5:56 AM
Unknown Object (File)
Fri, Dec 6, 1:34 PM
Unknown Object (File)
Tue, Dec 3, 4:22 PM
Unknown Object (File)
Mon, Dec 2, 9:53 AM
Unknown Object (File)
Nov 18 2024, 1:46 PM
Unknown Object (File)
Nov 14 2024, 12:45 AM
Subscribers
None

Details

Summary

Ref T10696. By default, node uses 1.5GB, which is enormous overkill for this service and can crowd out other services if it's running next to things like a database on the same host.

Provide a configuration option to adjust it via --max-old-space-size and default to 256MB. It only seems to need about 30M locally, so this should be plenty of headroom.

Test Plan

Ran bin/aphlict debug, things seemed OK.

It takes a long time (days?) to grow to 1.5GB so I can't easily test this locally without a lot of work, but I'll keep an eye on it in production.

Diff Detail

Repository
rP Phabricator
Branch
notify4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11748
Build 14719: Run Core Tests
Build 14718: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Add a "memory.hint" parameter to Aphlict.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 15 2016, 2:12 PM
This revision was automatically updated to reflect the committed changes.