Differential D15719

Add coverage tooltips in Diffusion file browse mode
ClosedPublic
Actions

Authored by epriestley on Apr 15 2016, 12:39 PM.

Tags

None

Referenced Files

	F14398417: D15719.diff
	Sun, Dec 22, 1:51 PM

	F14388412: D15719.id37880.diff
	Sat, Dec 21, 4:28 PM

	Unknown Object (File)
	Fri, Dec 20, 6:50 PM

	Unknown Object (File)
	Sat, Dec 7, 12:42 PM

	Unknown Object (File)
	Thu, Dec 5, 2:15 PM

	Unknown Object (File)
	Sun, Nov 24, 8:32 AM

	Unknown Object (File)
	Nov 8 2024, 10:42 PM

	Unknown Object (File)
	Nov 4 2024, 7:38 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10816: File-level coverage doesn't have tooltips

Commits

rP053400289469: Add coverage tooltips in Diffusion file browse mode

Summary

Fixes T10816. The way these work is a little unusual since these chunks of file-rendering code are unusuall performance-sensitive, so the Differential version doesn't adapt directly to Diffusion. Both can possibly be unified at some point in the future, although they do slightly different things.

Test Plan

coverage.png (614×1 px, 138 KB)

Diff Detail

Repository

Branch

ttip1

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/js/application/diffusion/behavior-diffusion-browse-file.js:1	JAVELIN5	`javelinsymbols` Not In Path

Unit

Tests Passed

Build Status

Buildable 11747
Build 14717: Run Core Tests
Build 14716: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37878.Apr 15 2016, 12:39 PM

epriestley retitled this revision from to Add coverage tooltips in Diffusion file browse mode.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10816: File-level coverage doesn't have tooltips.

epriestley mentioned this in T10816: File-level coverage doesn't have tooltips.Apr 15 2016, 12:45 PM

chad accepted this revision.Apr 15 2016, 1:50 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 15 2016, 1:50 PM

Closed by commit rP053400289469: Add coverage tooltips in Diffusion file browse mode (authored by epriestley, committed by epriestley). · Explain WhyApr 15 2016, 1:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

8 lines

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

14 lines

webroot/

rsrc/

js/

application/

diffusion/

behavior-diffusion-browse-file.js

47 lines

Diff 37878

resources/celerity/map.php

Loading...

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...

webroot/rsrc/js/application/diffusion/behavior-diffusion-browse-file.js

Loading...