Page MenuHomePhabricator

Use --master-data, not --dump-slave, in bin/storage dump
ClosedPublic

Authored by epriestley on Apr 14 2016, 9:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 6:43 AM
Unknown Object (File)
Sun, Mar 10, 11:50 AM
Unknown Object (File)
Fri, Mar 8, 12:15 PM
Unknown Object (File)
Feb 16 2024, 11:46 AM
Unknown Object (File)
Feb 16 2024, 11:46 AM
Unknown Object (File)
Feb 16 2024, 11:43 AM
Unknown Object (File)
Feb 16 2024, 9:46 AM
Unknown Object (File)
Feb 16 2024, 9:05 AM
Subscribers
None

Details

Summary

These flags do slightly different things, I actually want --master-data here. My test databases are setup half-weird and work with either statement, which is why I missed this.

Test Plan

Ran a dump against master, got the right CHANGE MASTER statement with no warnings.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use --master-data, not --dump-slave, in bin/storage dump.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2016, 9:55 PM
This revision was automatically updated to reflect the committed changes.