Page MenuHomePhabricator

Don't apply `security.require-https` to intracluster requests
ClosedPublic

Authored by epriestley on Apr 13 2016, 1:17 PM.
Tags
None
Referenced Files
F15502705: D15696.id37825.diff
Mon, Apr 14, 3:24 AM
F15433869: D15696.diff
Tue, Mar 25, 12:59 AM
F15430960: D15696.id37832.diff
Mon, Mar 24, 9:52 AM
F15424906: D15696.id37825.diff
Sun, Mar 23, 1:03 AM
F15399127: D15696.id.diff
Mar 17 2025, 3:01 AM
F15381670: D15696.diff
Mar 14 2025, 8:50 AM
Unknown Object (File)
Feb 24 2025, 7:29 PM
Unknown Object (File)
Feb 23 2025, 1:03 PM
Subscribers
None

Details

Summary

Ref T10784. Currently, if you terminate SSL at a load balancer (very common) and use HTTP beyond that, you have to fiddle with this setting in your premable or a SiteConfig.

On the balance I think this makes stuff much harder to configure without any real security benefit, so don't apply this option to intracluster requests.

Also document a lot of stuff.

Test Plan

Poked around locally but this is hard to test outside of a production cluster, I'll vet it more thoroughly on secure.

Diff Detail

Repository
rP Phabricator
Branch
crepo8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11686
Build 14630: Run Core Tests
Build 14629: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Don't apply `security.require-https` to intracluster requests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/docs/user/cluster/cluster.diviner
96

accessing? or access to?

This revision is now accepted and ready to land.Apr 13 2016, 4:28 PM
epriestley edited edge metadata.
  • Add missing "access to".
This revision was automatically updated to reflect the committed changes.