Page MenuHomePhabricator

Don't dead-end users with out-of-date links to files
ClosedPublic

Authored by epriestley on Apr 6 2016, 11:20 PM.

Details

Summary

Ref T10262. Instead of dumping an unhelpful 403 "ACCESS DENIED" page on users, explain the most likely cause of the issue and give them a link to return to the file detail page to learn more or get an up-to-date link.

Test Plan

Hit both errors, had a lovely experience with the helpful dialog text.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Don't dead-end users with out-of-date links to files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Apr 6 2016, 11:26 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2016, 11:26 PM
This revision was automatically updated to reflect the committed changes.