Differential D15650

Don't dead-end users with out-of-date links to files
ClosedPublic
Actions

Authored by epriestley on Apr 6 2016, 11:20 PM.

Details

Reviewers

chad

Maniphest Tasks

T10262: Scramble file secrets when attached objects change their view policies

Commits

rP5938d768d6ba: Don't dead-end users with out-of-date links to files

Summary

Ref T10262. Instead of dumping an unhelpful 403 "ACCESS DENIED" page on users, explain the most likely cause of the issue and give them a link to return to the file detail page to learn more or get an up-to-date link.

Test Plan

Hit both errors, had a lovely experience with the helpful dialog text.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37713.Apr 6 2016, 11:20 PM

epriestley retitled this revision from to Don't dead-end users with out-of-date links to files.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10262: Scramble file secrets when attached objects change their view policies.

chad accepted this revision.Apr 6 2016, 11:26 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 6 2016, 11:26 PM

Closed by commit rP5938d768d6ba: Don't dead-end users with out-of-date links to files (authored by epriestley, committed by epriestley). · Explain WhyApr 6 2016, 11:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

controller/

PhabricatorFileDataController.php

38 lines

Diff 37714

View Options

src/applications/files/controller/PhabricatorFileDataController.php

Don't dead-end users with out-of-date links to filesClosedPublicActions