Page MenuHomePhabricator
Differential D15638

Implement a rough optgroup-based "Move on Workboard" stacked action
ClosedPublic
Actions

Authored by epriestley on Apr 6 2016, 1:08 PM.
Tags
None
Referenced Files
F14397966: D15638.diff
Sun, Dec 22, 12:28 PM
Unknown Object (File)
Tue, Dec 17, 4:28 PM
Unknown Object (File)
Mon, Dec 16, 2:45 PM
Unknown Object (File)
Sat, Dec 14, 8:10 AM
Unknown Object (File)
Sun, Dec 8, 2:25 PM
Unknown Object (File)
Fri, Dec 6, 8:51 PM
Unknown Object (File)
Wed, Nov 27, 6:24 PM
Unknown Object (File)
Tue, Nov 26, 1:34 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T6027: Way to edit which column a task is in from the task itself
Commits
rP67629aab14b3: Implement a rough optgroup-based "Move on Workboard" stacked action
Summary

Ref T6027. Try this out and see how it feels? Clear issues:

  • This definitely shouldn't be at the top.
  • You should probably be able to select it multiple times?
  • Some of the "which columns show up" rules might need adjustment?
  • Diamond marker maybe not great?

Not sure I love this but it doesn't feel terrible...

Test Plan

Screen Shot 2016-04-06 at 5.58.31 AM.png (492×1 px, 59 KB)

Diff Detail

Repository
rP Phabricator
Branch
column5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11546
Build 14422: Run Core Tests
Build 14421: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37677.Apr 6 2016, 1:08 PM
epriestley retitled this revision from to Implement a rough optgroup-based "Move on Workboard" stacked action.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T6027: Way to edit which column a task is in from the task itself.
chad added inline comments.Apr 6 2016, 4:02 PM
src/applications/maniphest/editor/ManiphestEditEngine.php
426

yeah maybe just a checkmark?

epriestley added a comment.Apr 6 2016, 4:06 PM

Here's a checkmark version -- maybe better? Still seems a little weird to me.

Screen Shot 2016-04-06 at 9.04.26 AM.png (239×303 px, 25 KB)

Or we could do something like this?

Screen Shot 2016-04-06 at 9.06.09 AM.png (246×439 px, 27 KB)

chad accepted this revision.Apr 6 2016, 4:08 PM
chad edited edge metadata.

yeah lets start with the second one

This revision is now accepted and ready to land.Apr 6 2016, 4:08 PM
epriestley added a comment.Apr 6 2016, 4:10 PM

Sorry -- is the second one the checkmarks (the "second proposed approach") or "o•" (the "second screenshot in the comment")? :3

today is not a good brain day either for me tbqh

chad added a comment.Apr 6 2016, 4:11 PM

pasted_file (188×263 px, 18 KB)

epriestley added a comment.Apr 6 2016, 4:12 PM

cool I like this one (this one) too I think

Screen Shot 2016-04-06 at 9.11.50 AM.png (269×326 px, 41 KB)

that one

epriestley updated this revision to Diff 37680.Apr 6 2016, 4:12 PM
epriestley edited edge metadata.
  • Use empty and filled circles to show current column instead of diamonds.
Closed by commit rP67629aab14b3: Implement a rough optgroup-based "Move on Workboard" stacked action (authored by epriestley, committed by epriestley). · Explain WhyApr 6 2016, 4:15 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T6027: Way to edit which column a task is in from the task itself.Apr 6 2016, 4:26 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
2 lines
applications/
maniphest/
editor/
81 lines
transactions/
commentaction/
27 lines
editfield/
21 lines
webroot/
rsrc/
js/
phuix/
35 lines

Diff 37680

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...
View Options

src/applications/transactions/commentaction/PhabricatorEditEngineColumnsCommentAction.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorColumnsEditField.php

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXFormControl.js

Loading...
Phabricator · Built by Phacility