Page MenuHomePhabricator

Implement a rough optgroup-based "Move on Workboard" stacked action
ClosedPublic

Authored by epriestley on Apr 6 2016, 1:08 PM.

Details

Summary

Ref T6027. Try this out and see how it feels? Clear issues:

  • This definitely shouldn't be at the top.
  • You should probably be able to select it multiple times?
  • Some of the "which columns show up" rules might need adjustment?
  • Diamond marker maybe not great?

Not sure I love this but it doesn't feel terrible...

Test Plan

Screen Shot 2016-04-06 at 5.58.31 AM.png (492×1 px, 59 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement a rough optgroup-based "Move on Workboard" stacked action.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
src/applications/maniphest/editor/ManiphestEditEngine.php
426

yeah maybe just a checkmark?

Here's a checkmark version -- maybe better? Still seems a little weird to me.

Screen Shot 2016-04-06 at 9.04.26 AM.png (239×303 px, 25 KB)

Or we could do something like this?

Screen Shot 2016-04-06 at 9.06.09 AM.png (246×439 px, 27 KB)

chad edited edge metadata.

yeah lets start with the second one

This revision is now accepted and ready to land.Apr 6 2016, 4:08 PM

Sorry -- is the second one the checkmarks (the "second proposed approach") or "o•" (the "second screenshot in the comment")? :3

today is not a good brain day either for me tbqh

cool I like this one (this one) too I think

Screen Shot 2016-04-06 at 9.11.50 AM.png (269×326 px, 41 KB)

that one

epriestley edited edge metadata.
  • Use empty and filled circles to show current column instead of diamonds.
This revision was automatically updated to reflect the committed changes.