Page MenuHomePhabricator

Expose column positions via maniphest.edit
ClosedPublic

Authored by epriestley on Apr 6 2016, 11:38 AM.

Details

Summary

Ref T5214. Fixes T10486. Ref T6027. This exposes the TYPE_COLUMNS transaction in a usable way via API, and fixes the interactions via prefilling.

Test Plan
  • Created tasks directly into columns via API.
  • Moved tasks between columns via API.
  • Used ?column=... to try to create a template task with valid and bogus column PHIDs.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Expose column positions via maniphest.edit.Apr 6 2016, 11:38 AM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley updated this revision to Diff 37675.
chad edited edge metadata.Apr 6 2016, 3:36 PM
chad accepted this revision.
chad added inline comments.
src/applications/maniphest/editor/ManiphestEditEngine.php
112

an

This revision is now accepted and ready to land.Apr 6 2016, 3:36 PM
epriestley added inline comments.Apr 6 2016, 3:38 PM
src/applications/maniphest/editor/ManiphestEditEngine.php
112

why thank you :3

epriestley edited edge metadata.Apr 6 2016, 3:39 PM
epriestley updated this revision to Diff 37679.
  • "a" -> "an"
  • Also say "may select a position" instead of "should select a position", since you can do whatever you want!
This revision was automatically updated to reflect the committed changes.