Differential D15629

Add a session engine extension point
ClosedPublic
Actions

Authored by epriestley on Apr 5 2016, 10:03 PM.

Details

Reviewers

chad

Maniphest Tasks

T7673: Make "Log Out" on Phacility instances behave in a way better aligned with user expectation

Commits

rP46881c4ce507: Add a session engine extension point

Summary

Ref T7673. This is really just so I can force admin.phacility.com logout when you log out of an instance, but there are a few other things we could move here eventually, like the WILLREGISTERUSER event.

Test Plan

Logged out of an instance, got logged out of parent (see next change).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37662.Apr 5 2016, 10:03 PM

epriestley retitled this revision from to Add a session engine extension point.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T7673: Make "Log Out" on Phacility instances behave in a way better aligned with user expectation.

chad added inline comments.Apr 5 2016, 10:11 PM

src/applications/auth/engine/PhabricatorAuthSessionEngineExtensionModule.php
46	where does this show up?

In Config → stuff in the sidebar:

Screen Shot 2016-04-05 at 3.12.10 PM.png (991×1 px, 157 KB)

chad accepted this revision.Apr 5 2016, 10:12 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 5 2016, 10:12 PM

Closed by commit rP46881c4ce507: Add a session engine extension point (authored by epriestley, committed by epriestley). · Explain WhyApr 5 2016, 10:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

auth/

controller/

PhabricatorLogoutController.php

11 lines

engine/

PhabricatorAuthSessionEngine.php

18 lines

PhabricatorAuthSessionEngineExtension.php

23 lines

PhabricatorAuthSessionEngineExtensionModule.php

49 lines

provider/

PhabricatorPhabricatorAuthProvider.php

5 lines

query/

PhabricatorExternalAccountQuery.php

53 lines

people/

storage/

PhabricatorExternalAccount.php

8 lines

Diff 37666

View Options

src/__phutil_library_map__.php

View Options

src/applications/auth/controller/PhabricatorLogoutController.php

View Options

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

View Options

src/applications/auth/engine/PhabricatorAuthSessionEngineExtension.php

View Options

src/applications/auth/engine/PhabricatorAuthSessionEngineExtensionModule.php

View Options

src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php

View Options

src/applications/auth/query/PhabricatorExternalAccountQuery.php

View Options

src/applications/people/storage/PhabricatorExternalAccount.php

Add a session engine extension pointClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37666

src/__phutil_library_map__.php

src/applications/auth/controller/PhabricatorLogoutController.php

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

src/applications/auth/engine/PhabricatorAuthSessionEngineExtension.php

src/applications/auth/engine/PhabricatorAuthSessionEngineExtensionModule.php

src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php

src/applications/auth/query/PhabricatorExternalAccountQuery.php

src/applications/people/storage/PhabricatorExternalAccount.php

Add a session engine extension point
ClosedPublic
Actions

Revision Contents
Changeset List