Page MenuHomePhabricator
Differential D15611

Update typeahead for new UI
ClosedPublic
Actions

Authored by chad on Apr 4 2016, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 3:40 PM
Unknown Object (File)
Thu, Dec 26, 1:15 PM
Unknown Object (File)
Thu, Dec 19, 12:16 AM
Unknown Object (File)
Mon, Dec 9, 11:50 AM
Unknown Object (File)
Nov 28 2024, 8:14 PM
Unknown Object (File)
Nov 28 2024, 1:44 AM
Unknown Object (File)
Nov 19 2024, 5:06 AM
Unknown Object (File)
Nov 11 2024, 6:34 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP968a75b5792c: Update typeahead for new UI
Summary

Uses modern UI, newPage, etc. Changes table behavior to always scroll if too large for container, can't find anything this breaks, but be on the lookout.

Test Plan

Pull up help and view pages, search for some people and projects.

Diff Detail

Repository
rP Phabricator
Branch
typeahead-newpage (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11490
Build 14336: Run Core Tests
Build 14335: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37623.Apr 4 2016, 7:40 PM
chad retitled this revision from to Update typeahead for new UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptApr 4 2016, 7:40 PM
epriestley accepted this revision.Apr 4 2016, 7:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 4 2016, 7:41 PM
Closed by commit rP968a75b5792c: Update typeahead for new UI (authored by chad, committed by chad). · Explain WhyApr 4 2016, 7:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
typeahead/
controller/
15 lines
20 lines
webroot/
rsrc/
css/
aphront/
3 lines

Diff 37623

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
View Options

webroot/rsrc/css/aphront/table-view.css

Loading...
Phabricator · Built by Phacility