Page MenuHomePhabricator
Differential D15555

Allow ordering of badges by quality
ClosedPublic
Actions

Authored by lpriestley on Apr 1 2016, 12:06 AM.
Tags
None
Referenced Files
F14622275: D15555.id37506.diff
Fri, Jan 10, 9:19 AM
Unknown Object (File)
Wed, Jan 1, 8:15 PM
Unknown Object (File)
Sat, Dec 14, 4:50 PM
Unknown Object (File)
Dec 9 2024, 2:29 PM
Unknown Object (File)
Dec 7 2024, 5:13 PM
Unknown Object (File)
Dec 7 2024, 3:45 PM
Unknown Object (File)
Dec 4 2024, 5:47 AM
Unknown Object (File)
Dec 3 2024, 10:46 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9007: Allow Badges to be ordered by quality
Commits
rP7a6acd57faac: Allow ordering of badges by quality
Summary

Ref T9007

Test Plan

Navigate to "Advanced Search" in Badges, order by rarity, then by commonality. Rarest and most common badges should be ordered, respectively.

Diff Detail

Repository
rP Phabricator
Branch
badgesorderbyquality
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11387
Build 14181: Run Core Tests
Build 14180: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 37506.Apr 1 2016, 12:06 AM
lpriestley retitled this revision from to Allow ordering of badges by quality.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T9007: Allow Badges to be ordered by quality.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 1 2016, 12:06 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 1 2016, 12:32 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/badges/query/PhabricatorBadgesQuery.php
114

Maybe 'shoddiness'? :3

127

This one should just be int.

128

(You can omit this if you want, false is the default.)

This revision is now accepted and ready to land.Apr 1 2016, 12:32 AM
lpriestley updated this revision to Diff 37522.Apr 1 2016, 6:59 PM
lpriestley marked 3 inline comments as done.
lpriestley edited edge metadata.

Updating to shoddiness

Closed by commit rP7a6acd57faac: Allow ordering of badges by quality (authored by lpriestley, committed by lpriestley). · Explain WhyApr 1 2016, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
badges/
query/
32 lines

Diff 37522

View Options

src/applications/badges/query/PhabricatorBadgesQuery.php

Loading...
Phabricator · Built by Phacility