Fix run-on "pre" on project/profile feeds
ClosedPublic
Actions

Authored by chad on Mar 30 2016, 3:03 AM.

Details

Reviewers

epriestley

Commits

rP82f97b6b339a: Fix run-on "pre" on project/profile feeds

Summary

Because we layout profile navs with display: table-cell, it has unintended consequences with overflowing text boxes, like with pre. This causes the layouts to break, like a table might, with long content. For now, let's just line-wrap the pre like a terminal would.

Test Plan

"/opt/ghc-7.10.1-i386/bin/ghc" -hisuf hi -osuf  o -hcsuf hc -static  -H32m -O -Wall  -package-db libraries/bootstrapping.conf  -this-package-key ghc-7.11 -hide-all-packages -i -icompiler/backpack -icompiler/basicTypes -icompiler/cmm -icompiler/codeGen -icompiler/coreSyn -icompiler/deSugar -icompiler/ghci -icompiler/hsSyn -icompiler/iface -icompiler/llvmGen -icompiler/main -icompiler/nativeGen -icompiler/parser -icompiler/prelude -icompiler/profiling -icompiler/rename -icompiler/simplCore -icompiler/simplStg -icompiler/specialise -icompiler/stgSyn -icompiler/stranal -icompiler/typecheck -icompiler/types -icompiler/utils -icompiler/vectorise -icompiler/stage1/build -icompiler/stage1/build/autogen -Icompiler/stage1/build -Icompiler/stage1/build/autogen -Icompiler/. -Icompiler/parser -Icompiler/utils -Icompiler/stage1    -optP-include -optPcompiler/stage1/build/autogen/cabal_macros.h -package-id array-0.5.1.0-29bb26a0797af39b979b99b93e9d62fd -package-id base-4.8.0.0-82f21b46ed153fd6b19071a60f2e7937 -package-id binary-0.7.5.0 -package-id bytestring-0.10.6.0-79779027caa792766a3e8dc3e9cb98de -package-id containers-0.5.6.2-90712e174b339b5587c1656969878fb0 -package-id directory-1.2.2.0-73de5f636b1ca4c49aef15924617292c -package-id filepath-1.4.0.0-129f3fdd2b5de4f823a2641d7cf29327 -package-id ghc-boot-0.0.0.0 -package-id hoopl-3.10.2.0 -package-id hpc-0.6.0.2 -package-id process-1.2.3.0-77cd256a28bb4c7cc8cecb076a8fbc37 -package-id template-haskell-2.11.0.0 -package-id time-1.5.0.1-f5db9cf4a7dcb8716611e730437a1fd6 -package-id transformers-0.4.3.0 -package-id unix-2.7.1.0-57629c7ceba7cbcf210cc85471e45e07 -Wall -fno-warn-name-shadowing -this-package-key ghc -XHaskell2010 -DSTAGE=1 -Rghc-timing  -fwarn-tabs  -no-user-package-db -rtsopts      -odir compiler/stage1/build -hidir compiler/stage1/build -stubdir compiler/stage1/build    -c compiler/utils/Outputable.hs -o compiler/stage1/build/Outputable.o

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 37484.Mar 30 2016, 3:03 AM

chad retitled this revision from to Fix run on "pre" on project/profile feeds.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 30 2016, 3:03 AM

chad retitled this revision from Fix run on "pre" on project/profile feeds to Fix run-on "pre" on project/profile feeds.Mar 30 2016, 3:03 AM

This is the issue, right?

Screen Shot 2016-03-29 at 8.05.44 PM.png (318×1 px, 50 KB)

This revision is now accepted and ready to land.Mar 30 2016, 3:06 AM

Yeah, tables... i think don't have a "width" or something, I forget, so it doesn't know where to overflow it. I should probably re-write the nav to not use tables, but that may or may not be simple.

Closed by commit rP82f97b6b339a: Fix run-on "pre" on project/profile feeds (authored by chad, committed by chad). · Explain WhyMar 30 2016, 3:09 AM

This revision was automatically updated to reflect the committed changes.

thoughtpolice awarded a token.Mar 30 2016, 2:40 PM