Page MenuHomePhabricator

Adding basic transaction titles to awarding/revoking badges
ClosedPublic

Authored by lpriestley on Mar 28 2016, 4:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 29, 12:53 PM
Unknown Object (File)
Tue, Dec 3, 1:47 PM
Unknown Object (File)
Nov 26 2024, 4:25 PM
Unknown Object (File)
Nov 18 2024, 11:58 PM
Unknown Object (File)
Nov 8 2024, 6:54 PM
Unknown Object (File)
Nov 5 2024, 5:21 AM
Unknown Object (File)
Nov 3 2024, 9:09 AM
Unknown Object (File)
Oct 23 2024, 2:37 AM
Subscribers
Tokens
"Haypence" token, awarded by chad.

Details

Summary

Ref T10677, awarding/revoking a badge should create timeline entries with titles that are more clear (excludes homepage feed stories)

Test Plan

Award/revoke a badge to single or multiple users. See timeline entries that reflect those actions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Adding basic transaction titles to awarding/revoking badges.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/badges/storage/PhabricatorBadgesTransaction.php
118

This reads a little awkwardly to me -- maybe "%s awarded this badge to %s recipient(s): %s"?

128

This too -- maybe "%s revoked this badge from %s recipient(s): %s"?

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
1532–1544

If you do make wording changes, update these too.

This revision is now accepted and ready to land.Mar 28 2016, 4:33 PM
lpriestley marked 3 inline comments as done.
lpriestley edited edge metadata.

Updating to epriestley wording

This revision was automatically updated to reflect the committed changes.