Differential D15531

Update EditEngine for two column
ClosedPublic
Actions

Authored by chad on Mar 28 2016, 4:08 PM.

Details

Reviewers

epriestley

Commits

rPa939bbc4fa21: Update EditEngine for two column

Summary

Cleans up EditEngine, adds new layout to EditEngine and descendents

Test Plan

Test creating a new form, reordering, marking and unmarking defaults. View new forms.

Diff Detail

Repository

rP Phabricator

Branch

edit-engine-two (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11307
Build 14061: Run Core Tests
Build 14060: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37443.Mar 28 2016, 4:08 PM

chad retitled this revision from to Update EditEngine for two column.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 28 2016, 4:08 PM

epriestley accepted this revision.Mar 28 2016, 4:12 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 28 2016, 4:12 PM

Closed by commit rPa939bbc4fa21: Update EditEngine for two column (authored by chad, committed by chad). · Explain WhyMar 28 2016, 4:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

src/

applications/

almanac/

editor/

AlmanacBindingPropertyEditEngine.php

4 lines

AlmanacDeviceEditEngine.php

4 lines

AlmanacDevicePropertyEditEngine.php

4 lines

AlmanacNamespaceEditEngine.php

4 lines

AlmanacNetworkEditEngine.php

4 lines

AlmanacServiceEditEngine.php

4 lines

AlmanacServicePropertyEditEngine.php

4 lines

badges/

editor/

PhabricatorBadgesEditEngine.php

6 lines

drydock/

editor/

DrydockBlueprintEditEngine.php

4 lines

harbormaster/

editor/

HarbormasterBuildPlanEditEngine.php

4 lines

maniphest/

editor/

ManiphestEditEngine.php

6 lines

nuance/

editor/

NuanceQueueEditEngine.php

4 lines

NuanceSourceEditEngine.php

4 lines

owners/

editor/

PhabricatorOwnersPackageEditEngine.php

6 lines

paste/

editor/

PhabricatorPasteEditEngine.php

4 lines

phame/

editor/

PhameBlogEditEngine.php

4 lines

PhamePostEditEngine.php

4 lines

project/

engine/

PhabricatorProjectEditEngine.php

6 lines

search/

editor/

PhabricatorProfilePanelEditEngine.php

4 lines

transactions/

controller/

PhabricatorEditEngineConfigurationDefaultsController.php

20 lines

PhabricatorEditEngineConfigurationViewController.php

79 lines

editengine/

PhabricatorEditEngine.php

25 lines

editor/

PhabricatorEditEngineConfigurationEditEngine.php

4 lines

query/

PhabricatorEditEngineConfigurationSearchEngine.php

13 lines

storage/

PhabricatorEditEngineConfigurationTransaction.php

43 lines

webroot/

rsrc/

css/

phui/

phui-two-column-view.css

2 lines

Diff 37443

View Options

resources/celerity/map.php

View Options

src/applications/almanac/editor/AlmanacBindingPropertyEditEngine.php

View Options

src/applications/almanac/editor/AlmanacDeviceEditEngine.php

View Options

src/applications/almanac/editor/AlmanacDevicePropertyEditEngine.php

View Options

src/applications/almanac/editor/AlmanacNamespaceEditEngine.php

View Options

src/applications/almanac/editor/AlmanacNetworkEditEngine.php

View Options

src/applications/almanac/editor/AlmanacServiceEditEngine.php

View Options

src/applications/almanac/editor/AlmanacServicePropertyEditEngine.php

View Options

src/applications/badges/editor/PhabricatorBadgesEditEngine.php

View Options

src/applications/drydock/editor/DrydockBlueprintEditEngine.php

View Options

src/applications/harbormaster/editor/HarbormasterBuildPlanEditEngine.php

View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

View Options

src/applications/nuance/editor/NuanceQueueEditEngine.php

View Options

src/applications/nuance/editor/NuanceSourceEditEngine.php

View Options

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

View Options

src/applications/paste/editor/PhabricatorPasteEditEngine.php

View Options

src/applications/phame/editor/PhameBlogEditEngine.php

View Options

src/applications/phame/editor/PhamePostEditEngine.php

View Options

src/applications/project/engine/PhabricatorProjectEditEngine.php

View Options

src/applications/search/editor/PhabricatorProfilePanelEditEngine.php

View Options

src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php

View Options

src/applications/transactions/controller/PhabricatorEditEngineConfigurationViewController.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

View Options

src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php

View Options

src/applications/transactions/query/PhabricatorEditEngineConfigurationSearchEngine.php

View Options

src/applications/transactions/storage/PhabricatorEditEngineConfigurationTransaction.php

View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Update EditEngine for two columnClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37443

resources/celerity/map.php

src/applications/almanac/editor/AlmanacBindingPropertyEditEngine.php

src/applications/almanac/editor/AlmanacDeviceEditEngine.php

src/applications/almanac/editor/AlmanacDevicePropertyEditEngine.php

src/applications/almanac/editor/AlmanacNamespaceEditEngine.php

src/applications/almanac/editor/AlmanacNetworkEditEngine.php

src/applications/almanac/editor/AlmanacServiceEditEngine.php

src/applications/almanac/editor/AlmanacServicePropertyEditEngine.php

src/applications/badges/editor/PhabricatorBadgesEditEngine.php

src/applications/drydock/editor/DrydockBlueprintEditEngine.php

src/applications/harbormaster/editor/HarbormasterBuildPlanEditEngine.php

src/applications/maniphest/editor/ManiphestEditEngine.php

src/applications/nuance/editor/NuanceQueueEditEngine.php

src/applications/nuance/editor/NuanceSourceEditEngine.php

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

src/applications/paste/editor/PhabricatorPasteEditEngine.php

src/applications/phame/editor/PhameBlogEditEngine.php

src/applications/phame/editor/PhamePostEditEngine.php

src/applications/project/engine/PhabricatorProjectEditEngine.php

src/applications/search/editor/PhabricatorProfilePanelEditEngine.php

src/applications/transactions/controller/PhabricatorEditEngineConfigurationDefaultsController.php

src/applications/transactions/controller/PhabricatorEditEngineConfigurationViewController.php

src/applications/transactions/editengine/PhabricatorEditEngine.php

src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php

src/applications/transactions/query/PhabricatorEditEngineConfigurationSearchEngine.php

src/applications/transactions/storage/PhabricatorEditEngineConfigurationTransaction.php

webroot/rsrc/css/phui/phui-two-column-view.css

Update EditEngine for two column
ClosedPublic
Actions

Revision Contents
Changeset List