Differential D15526

Set blue background (unless it looks terrible)
ClosedPublic
Actions

Authored by epriestley on Mar 25 2016, 10:55 PM.

Details

Reviewers

chad

Commits

rP4a69854248c1: (stable) Promote 2016 Week 13
rPd784d9c0440c: Set blue background (unless it looks terrible)

Summary

See D15525.

Test Plan

Screen Shot 2016-03-25 at 3.54.43 PM.png (1×1 px, 286 KB)

Diff Detail

Repository

rP Phabricator

Branch

habor3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11292
Build 14040: Run Core Tests
Build 14039: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37429.Mar 25 2016, 10:55 PM

epriestley retitled this revision from to Set blue background (unless it looks terrible).

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald edited edge metadata. · View Herald TranscriptMar 25 2016, 10:55 PM

Think we'd ever have more than this single action? If that's the only action, could make it a button on the header and have the table full width

This revision is now accepted and ready to land.Mar 25 2016, 10:56 PM

Or is it even needed with crumbs?

I think there was some other stuff I was planning to put there but I forget what it was.

I'm just going to leave it for now and we can remove/buttonize it later if I don't remember by the next time I'm touching this.

Closed by commit rPd784d9c0440c: Set blue background (unless it looks terrible) (authored by epriestley, committed by epriestley). · Explain WhyMar 25 2016, 10:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterUnitMessageViewController.php

3 lines

Diff 37429

View Options

src/applications/harbormaster/controller/HarbormasterUnitMessageViewController.php

Set blue background (unless it looks terrible)ClosedPublicActions