Differential D15516

Improve rendering of many GitHub event strings
ClosedPublic
Actions

Authored by epriestley on Mar 24 2016, 1:03 PM.

Details

Reviewers

chad

Maniphest Tasks

T10538: Bridge GitHub to Phabricator

Commits

Restricted Diffusion Commit
rP7cfc87bbe65e: Improve rendering of many GitHub event strings

Summary

Ref T10538. This makes us render better human-readable descriptions of more GitHub event types.

Test Plan

Ran unit tests.

Diff Detail

Repository

rP Phabricator

Branch

nuance23

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11271
Build 14005: Run Core Tests
Build 14004: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37408.Mar 24 2016, 1:03 PM

epriestley retitled this revision from to Improve rendering of many GitHub event strings.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10538: Bridge GitHub to Phabricator.

Herald edited edge metadata. · View Herald TranscriptMar 24 2016, 1:03 PM

chad accepted this revision.Mar 24 2016, 3:08 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 24 2016, 3:08 PM

Closed by commit rP7cfc87bbe65e: Improve rendering of many GitHub event strings (authored by epriestley, committed by epriestley). · Explain WhyMar 24 2016, 3:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

nuance/

github/

NuanceGitHubRawEvent.php

172 lines

__tests__/

NuanceGitHubRawEventTestCase.php

1 line

issueevents/

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

repositoryevents/

	CreateEvent.tag.txt
	WatchEvent.started.txt

18 lines

IssueCommentEvent.created.pull.txt

3 lines

IssueCommentEvent.created.txt

3 lines

IssuesEvent.closed.txt

3 lines

IssuesEvent.opened.txt

3 lines

IssuesEvent.reopened.txt

3 lines

PullRequestEvent.opened.txt

3 lines

PushEvent.txt

3 lines

WatchEvent.started.txt

3 lines

item/

NuanceGitHubEventItemType.php

54 lines

Diff 37408

View Options

src/applications/nuance/github/NuanceGitHubRawEvent.php

View Options

src/applications/nuance/github/tests/NuanceGitHubRawEventTestCase.php

View Options

src/applications/nuance/github/tests/issueevents/assigned.txt

View Options

src/applications/nuance/github/tests/issueevents/closed.txt

View Options

src/applications/nuance/github/tests/issueevents/demilestoned.txt

View Options

src/applications/nuance/github/tests/issueevents/labeled.txt

View Options

src/applications/nuance/github/tests/issueevents/locked.txt

View Options

src/applications/nuance/github/tests/issueevents/milestoned.txt

View Options

src/applications/nuance/github/tests/issueevents/renamed.txt

View Options

src/applications/nuance/github/tests/issueevents/reopened.txt

View Options

src/applications/nuance/github/tests/issueevents/unassigned.txt

View Options

src/applications/nuance/github/tests/issueevents/unlabeled.txt

View Options

src/applications/nuance/github/tests/issueevents/unlocked.txt

View Options

src/applications/nuance/github/tests/repositoryevents/CreateEvent.tag.txt

View Options

src/applications/nuance/github/tests/repositoryevents/IssueCommentEvent.created.pull.txt

View Options

src/applications/nuance/github/tests/repositoryevents/IssueCommentEvent.created.txt

View Options

src/applications/nuance/github/tests/repositoryevents/IssuesEvent.closed.txt

View Options

src/applications/nuance/github/tests/repositoryevents/IssuesEvent.opened.txt

View Options

src/applications/nuance/github/tests/repositoryevents/IssuesEvent.reopened.txt

View Options

src/applications/nuance/github/tests/repositoryevents/PullRequestEvent.opened.txt

View Options

src/applications/nuance/github/tests/repositoryevents/PushEvent.txt

View Options

src/applications/nuance/github/tests/repositoryevents/WatchEvent.started.txt

View Options

src/applications/nuance/item/NuanceGitHubEventItemType.php

Improve rendering of many GitHub event stringsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37408

src/applications/nuance/github/NuanceGitHubRawEvent.php

src/applications/nuance/github/__tests__/NuanceGitHubRawEventTestCase.php

src/applications/nuance/github/__tests__/issueevents/assigned.txt

src/applications/nuance/github/__tests__/issueevents/closed.txt

src/applications/nuance/github/__tests__/issueevents/demilestoned.txt

src/applications/nuance/github/__tests__/issueevents/labeled.txt

src/applications/nuance/github/__tests__/issueevents/locked.txt

src/applications/nuance/github/__tests__/issueevents/milestoned.txt

src/applications/nuance/github/__tests__/issueevents/renamed.txt

src/applications/nuance/github/__tests__/issueevents/reopened.txt

src/applications/nuance/github/__tests__/issueevents/unassigned.txt

src/applications/nuance/github/__tests__/issueevents/unlabeled.txt

src/applications/nuance/github/__tests__/issueevents/unlocked.txt

src/applications/nuance/github/__tests__/repositoryevents/CreateEvent.tag.txt

src/applications/nuance/github/__tests__/repositoryevents/IssueCommentEvent.created.pull.txt

src/applications/nuance/github/__tests__/repositoryevents/IssueCommentEvent.created.txt

src/applications/nuance/github/__tests__/repositoryevents/IssuesEvent.closed.txt

src/applications/nuance/github/__tests__/repositoryevents/IssuesEvent.opened.txt

src/applications/nuance/github/__tests__/repositoryevents/IssuesEvent.reopened.txt

src/applications/nuance/github/__tests__/repositoryevents/PullRequestEvent.opened.txt

src/applications/nuance/github/__tests__/repositoryevents/PushEvent.txt

src/applications/nuance/github/__tests__/repositoryevents/WatchEvent.started.txt

src/applications/nuance/item/NuanceGitHubEventItemType.php

Improve rendering of many GitHub event strings
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/nuance/github/tests/NuanceGitHubRawEventTestCase.php

src/applications/nuance/github/tests/issueevents/assigned.txt

src/applications/nuance/github/tests/issueevents/closed.txt

src/applications/nuance/github/tests/issueevents/demilestoned.txt

src/applications/nuance/github/tests/issueevents/labeled.txt

src/applications/nuance/github/tests/issueevents/locked.txt

src/applications/nuance/github/tests/issueevents/milestoned.txt

src/applications/nuance/github/tests/issueevents/renamed.txt

src/applications/nuance/github/tests/issueevents/reopened.txt

src/applications/nuance/github/tests/issueevents/unassigned.txt

src/applications/nuance/github/tests/issueevents/unlabeled.txt

src/applications/nuance/github/tests/issueevents/unlocked.txt

src/applications/nuance/github/tests/repositoryevents/CreateEvent.tag.txt

src/applications/nuance/github/tests/repositoryevents/IssueCommentEvent.created.pull.txt

src/applications/nuance/github/tests/repositoryevents/IssueCommentEvent.created.txt

src/applications/nuance/github/tests/repositoryevents/IssuesEvent.closed.txt

src/applications/nuance/github/tests/repositoryevents/IssuesEvent.opened.txt

src/applications/nuance/github/tests/repositoryevents/IssuesEvent.reopened.txt

src/applications/nuance/github/tests/repositoryevents/PullRequestEvent.opened.txt

src/applications/nuance/github/tests/repositoryevents/PushEvent.txt

src/applications/nuance/github/tests/repositoryevents/WatchEvent.started.txt