Page MenuHomePhabricator

Fix an initialization issue in Herald rules in Chrome
ClosedPublic

Authored by epriestley on Mar 22 2016, 4:11 PM.
Tags
None
Referenced Files
F14025513: D15507.diff
Thu, Nov 7, 6:42 PM
F14009440: D15507.id37378.diff
Wed, Oct 30, 5:28 PM
F14007308: D15507.diff
Tue, Oct 29, 3:30 AM
F14004128: D15507.diff
Sat, Oct 26, 3:52 PM
F13999498: D15507.diff
Thu, Oct 24, 3:12 PM
F13999064: D15507.id.diff
Thu, Oct 24, 12:42 PM
F13980929: D15507.id37378.diff
Sat, Oct 19, 1:22 PM
F13976443: D15507.id37378.diff
Fri, Oct 18, 2:17 PM
Subscribers
None

Details

Summary

Fixes T10646. When you load the page or click "New Condition" or "New Action", we try to add a condition and action with some default values.

Currently, the logic just sets everything to null or 'default'. This technically works in Safari, but is less successful in Chrome. (I think Safari prevents you from picking an invalid value.)

Instead of relying on the browser to pick the right value, set the correct value explicitly.

Test Plan
  • Created a new rule in Chrome, Safari.
  • Added fields and conditions in Chrome, Safari.
  • Edited existing rules in Chrome, Safari.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an initialization issue in Herald rules in Chrome.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 22 2016, 4:12 PM
This revision was automatically updated to reflect the committed changes.