Paths

Table of Contentst

Differential D15489

Implement a Git LFS link table and basic batch API
ClosedPublic
Actions

Authored by epriestley on Mar 17 2016, 8:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 9:08 AM

	Unknown Object (File)
	Thu, Apr 11, 3:00 AM

	Unknown Object (File)
	Mon, Apr 8, 12:30 AM

	Unknown Object (File)
	Mon, Apr 1, 12:20 AM

	Unknown Object (File)
	Feb 14 2024, 3:37 PM

	Unknown Object (File)
	Feb 13 2024, 2:31 PM

	Unknown Object (File)
	Feb 3 2024, 9:14 AM

	Unknown Object (File)
	Feb 3 2024, 8:00 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T7789: Support Git Large File Storage

Commits

Restricted Diffusion Commit
rPf46686ff586d: Implement a Git LFS link table and basic batch API

Summary

Ref T7789. This implements:

A new table to store the <objectHash, filePHID> relationship between Git LFS files and Phabricator file objects.
A basic response to batch commands, which return actions for a list of files.

Test Plan

Ran git lfs push origin master, got a little further than previously:

epriestley@orbital ~/dev/scratch/poemslocal $ git lfs push origin master
Git LFS: (2 of 1 files) 174.24 KB / 87.12 KB                                                                                                                             
Git LFS operation "upload/b7e0aeb82a03d627c6aa5fc1bbfd454b6789d9d9affc8607d40168fa18cf6c69" is not supported by this server.
Git LFS operation "upload/b7e0aeb82a03d627c6aa5fc1bbfd454b6789d9d9affc8607d40168fa18cf6c69" is not supported by this server.

With GIT_TRACE=1, this shows the batch part of the API going through.

Diff Detail

Repository

Branch

lfs10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11198
Build 13895: Run Core Tests
Build 13894: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37338.Mar 17 2016, 8:33 PM

epriestley retitled this revision from to Implement a Git LFS link table and basic batch API.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T7789: Support Git Large File Storage.

Herald edited edge metadata. · View Herald TranscriptMar 17 2016, 8:33 PM

chad accepted this revision.Mar 17 2016, 8:43 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 17 2016, 8:43 PM

Closed by commit rPf46686ff586d: Implement a Git LFS link table and basic batch API (authored by epriestley, committed by epriestley). · Explain WhyMar 18 2016, 12:15 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T7789: Support Git Large File Storage.Mar 18 2016, 1:42 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20160317.lfs.01.ref.sql

11 lines

src/

__phutil_library_map__.php

7 lines

applications/

diffusion/

controller/

DiffusionServeController.php

145 lines

gitlfs/

DiffusionGitLFSAuthenticateWorkflow.php

24 lines

DiffusionGitLFSTemporaryTokenType.php

24 lines

repository/

query/

PhabricatorRepositoryGitLFSRefQuery.php

64 lines

storage/

PhabricatorRepositoryGitLFSRef.php

51 lines

Diff 37338

resources/sql/autopatches/20160317.lfs.01.ref.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/diffusion/controller/DiffusionServeController.php

Loading...

src/applications/diffusion/gitlfs/DiffusionGitLFSAuthenticateWorkflow.php

Loading...

src/applications/diffusion/gitlfs/DiffusionGitLFSTemporaryTokenType.php

Loading...

src/applications/repository/query/PhabricatorRepositoryGitLFSRefQuery.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryGitLFSRef.php

Loading...