Page MenuHomePhabricator

Implement a Git LFS server which supports no operations
ClosedPublic

Authored by epriestley on Mar 16 2016, 7:49 PM.
Tags
None
Attached Files
F10748189: D15485.id37318.diff
Mon, May 23, 1:54 AM
Unknown Object (File)
Apr 14 2017, 6:00 AM
Unknown Object (File)
Apr 12 2017, 5:35 PM
Unknown Object (File)
Mar 8 2017, 12:57 AM
Unknown Object (File)
Mar 7 2017, 7:50 AM
Unknown Object (File)
Mar 5 2017, 6:02 AM
Unknown Object (File)
Feb 27 2017, 2:33 AM
Unknown Object (File)
Feb 8 2017, 12:36 AM
Subscribers

Details

Summary

Ref T7789. This builds on top of git-lfs-authenticate to detect LFS requests, read LFS tokens, and route them to a handler which can do useful things.

This handler promptly drops them on the floor with an error message.

Test Plan

Here's a transcript showing the parts working together so far:

  • git-lfs connects to the server with SSH, and gets told how to connect with HTTP to do uploads.
  • git-lfs uses HTTP, and authenticates with the tokens properly.
  • But the server tells it to go away, and that it doesn't support anything, so the operation ultimately fails.
$ GIT_TRACE=1 git lfs push origin master
12:45:56.153913 git.c:558               trace: exec: 'git-lfs' 'push' 'origin' 'master'
12:45:56.154376 run-command.c:335       trace: run_command: 'git-lfs' 'push' 'origin' 'master'
trace git-lfs: Upload refs origin to remote [master]
trace git-lfs: run_command: git rev-list --objects master --not --remotes=origin
trace git-lfs: run_command: git cat-file --batch-check
trace git-lfs: run_command: git cat-file --batch
trace git-lfs: run_command: 'git' config -l
trace git-lfs: tq: starting 3 transfer workers
trace git-lfs: tq: running as batched queue, batch size of 100
trace git-lfs: prepare upload: b7e0aeb82a03d627c6aa5fc1bbfd454b6789d9d9affc8607d40168fa18cf6c69 lfs/dog1.jpg 1/1
trace git-lfs: tq: sending batch of size 1
trace git-lfs: ssh: local@localvault.phacility.com git-lfs-authenticate diffusion/18/poems.git upload 
trace git-lfs: api: batch 1 files
trace git-lfs: HTTP: POST http://local.phacility.com/diffusion/POEMS/poems.git/info/lfs/objects/batch
trace git-lfs: HTTP: 404
trace git-lfs: HTTP: {"message":"Git LFS operation \"objects\/batch\" is not supported by this server."}
trace git-lfs: HTTP: 
trace git-lfs: api: batch not implemented: 404
trace git-lfs: run_command: 'git' config lfs.batch false
trace git-lfs: tq: batch api not implemented, falling back to individual
trace git-lfs: ssh: local@localvault.phacility.com git-lfs-authenticate diffusion/18/poems.git upload b7e0aeb82a03d627c6aa5fc1bbfd454b6789d9d9affc8607d40168fa18cf6c69
trace git-lfs: api: uploading (b7e0aeb82a03d627c6aa5fc1bbfd454b6789d9d9affc8607d40168fa18cf6c69)
trace git-lfs: HTTP: POST http://local.phacility.com/diffusion/POEMS/poems.git/info/lfs/objects
trace git-lfs: HTTP: 404
trace git-lfs: HTTP: {"message":"Git LFS operation \"objects\" is not supported by this server."}
trace git-lfs: HTTP: 
trace git-lfs: tq: retrying 1 failed transfers
trace git-lfs: ssh: local@localvault.phacility.com git-lfs-authenticate diffusion/18/poems.git upload b7e0aeb82a03d627c6aa5fc1bbfd454b6789d9d9affc8607d40168fa18cf6c69
trace git-lfs: api: uploading (b7e0aeb82a03d627c6aa5fc1bbfd454b6789d9d9affc8607d40168fa18cf6c69)
trace git-lfs: HTTP: POST http://local.phacility.com/diffusion/POEMS/poems.git/info/lfs/objects
trace git-lfs: HTTP: 404
trace git-lfs: HTTP: {"message":"Git LFS operation \"objects\" is not supported by this server."}
trace git-lfs: HTTP: 
Git LFS: (0 of 1 files) 0 B / 87.12 KB                                                                                                                                                                                     
Git LFS operation "objects" is not supported by this server.
Git LFS operation "objects" is not supported by this server.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement a Git LFS server which supports no operations.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley edited edge metadata.
  • Add an extra sanity check to prevent tokens from one repository from being used on a different repository (this should be moot, but better safe than sorry).
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2016, 8:15 PM

look at all that console output tho

something with that much console output must be working well

epriestley edited edge metadata.
  • One additional sanity check.
This revision was automatically updated to reflect the committed changes.