Page MenuHomePhabricator
Differential D15467

Convert Drydock to two column layout
ClosedPublic
Actions

Authored by chad on Mar 13 2016, 1:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 2:22 PM
Unknown Object (File)
Thu, Jan 30, 6:03 PM
Unknown Object (File)
Tue, Jan 28, 1:09 AM
Unknown Object (File)
Thu, Jan 23, 7:21 PM
Unknown Object (File)
Jan 12 2025, 8:24 PM
Unknown Object (File)
Dec 17 2024, 6:44 AM
Unknown Object (File)
Dec 11 2024, 4:40 AM
Unknown Object (File)
Dec 7 2024, 3:01 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP301ecdef18a3: Convert Drydock to two column layout
Summary

Updates Drydock to use two column + curtain layouts.

Test Plan

Tested what I could get to, need @epriestley to run this locally for edge cases.

Diff Detail

Repository
rP Phabricator
Branch
drydock-two (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11149
Build 13821: Run Core Tests
Build 13820: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37279.Mar 13 2016, 1:50 AM
chad retitled this revision from to Convert Drydock to two column layout.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a subscriber: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 13 2016, 1:50 AM
epriestley accepted this revision.Mar 13 2016, 2:52 PM
epriestley edited edge metadata.

One inline. They end up looking a little weird since there are no actions, but this UI is far off the beaten path anyway:

Screen Shot 2016-03-13 at 7.51.59 AM.png (883×1 px, 142 KB)

I didn't catch any issues elsewhere.

src/applications/drydock/controller/DrydockRepositoryOperationViewController.php
71

This should be newCurtainView($operation).

This revision is now accepted and ready to land.Mar 13 2016, 2:52 PM
chad updated this revision to Diff 37284.Mar 13 2016, 3:09 PM
chad marked an inline comment as done.
chad edited edge metadata.
  • missed $operation
Closed by commit rP301ecdef18a3: Convert Drydock to two column layout (authored by chad, committed by chad). · Explain WhyMar 13 2016, 3:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37284

View Options

src/applications/drydock/controller/DrydockAuthorizationViewController.php

Loading...
View Options

src/applications/drydock/controller/DrydockBlueprintViewController.php

Loading...
View Options

src/applications/drydock/controller/DrydockController.php

Loading...
View Options

src/applications/drydock/controller/DrydockLeaseViewController.php

Loading...
View Options

src/applications/drydock/controller/DrydockRepositoryOperationViewController.php

Loading...
View Options

src/applications/drydock/controller/DrydockResourceViewController.php

Loading...
View Options

src/applications/drydock/view/DrydockRepositoryOperationStatusView.php

Loading...
Phabricator · Built by Phacility