Page MenuHomePhabricator

Stop moving "Cc" addresses to "To" when building mail targets
ClosedPublic

Authored by epriestley on Mar 12 2016, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 9:07 PM
Unknown Object (File)
Wed, Dec 4, 11:38 AM
Unknown Object (File)
Tue, Dec 3, 12:04 PM
Unknown Object (File)
Sat, Nov 30, 1:45 PM
Unknown Object (File)
Fri, Nov 29, 9:57 AM
Unknown Object (File)
Wed, Nov 27, 3:12 AM
Unknown Object (File)
Sat, Nov 23, 7:49 AM
Unknown Object (File)
Tue, Nov 19, 5:47 AM
Subscribers
None

Details

Summary

Fixes T10539. When building mail targets, we fail to preserve whether a recipient was originally "To" or "Cc", and just move everyone to "To".

Test Plan

Added a comment to a task with a "To" user and a "Cc" user, with metamta.placeholder-to-recipient set and metamta.one-mail-per-recipient set.

Got mail with me Cc'd as the Cc'd user:

tocc.png (327×470 px, 36 KB)

Diff Detail

Repository
rP Phabricator
Branch
mtarget1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11133
Build 13796: Run Core Tests
Build 13795: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Stop moving "Cc" addresses to "To" when building mail targets.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

I haven't actually tested this properly yet since my local task queue has like 30K commits to parse from the dummy repository I built in T10368. Once the queue flushes I'll make sure this actually works.

epriestley edited edge metadata.
  • Now with testing!
epriestley edited edge metadata.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2016, 3:17 PM
This revision was automatically updated to reflect the committed changes.