Page MenuHomePhabricator
Differential D15465

Stop moving "Cc" addresses to "To" when building mail targets
ClosedPublic
Actions

Authored by epriestley on Mar 12 2016, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 9:07 PM
Unknown Object (File)
Wed, Dec 4, 11:38 AM
Unknown Object (File)
Tue, Dec 3, 12:04 PM
Unknown Object (File)
Sat, Nov 30, 1:45 PM
Unknown Object (File)
Fri, Nov 29, 9:57 AM
Unknown Object (File)
Wed, Nov 27, 3:12 AM
Unknown Object (File)
Sat, Nov 23, 7:49 AM
Unknown Object (File)
Tue, Nov 19, 5:47 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10539: Email not respecting TO and CC
Commits
Restricted Diffusion Commit
rPba9cd64e514e: Stop moving "Cc" addresses to "To" when building mail targets
Summary

Fixes T10539. When building mail targets, we fail to preserve whether a recipient was originally "To" or "Cc", and just move everyone to "To".

Test Plan

Added a comment to a task with a "To" user and a "Cc" user, with metamta.placeholder-to-recipient set and metamta.one-mail-per-recipient set.

Got mail with me Cc'd as the Cc'd user:

tocc.png (327×470 px, 36 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37268.Mar 12 2016, 12:04 AM
epriestley retitled this revision from to Stop moving "Cc" addresses to "To" when building mail targets.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10539: Email not respecting TO and CC .
Herald edited edge metadata. · View Herald TranscriptMar 12 2016, 12:04 AM
epriestley planned changes to this revision.Mar 12 2016, 12:05 AM

I haven't actually tested this properly yet since my local task queue has like 30K commits to parse from the dummy repository I built in T10368. Once the queue flushes I'll make sure this actually works.

epriestley updated this revision to Diff 37270.Mar 12 2016, 1:19 PM
epriestley edited edge metadata.
  • Now with testing!
Herald edited edge metadata. · View Herald TranscriptMar 12 2016, 1:19 PM
epriestley edited the test plan for this revision. (Show Details)Mar 12 2016, 1:24 PM
epriestley edited edge metadata.
chad accepted this revision.Mar 12 2016, 3:17 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2016, 3:17 PM
Closed by commit rPba9cd64e514e: Stop moving "Cc" addresses to "To" when building mail targets (authored by epriestley, committed by epriestley). · Explain WhyMar 12 2016, 3:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
metamta/
replyhandler/
13 lines

Diff 37272

View Options

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

Loading...
Phabricator · Built by Phacility