Paths

Table of Contentst

Differential D15464

Fix a minor issue in Nuance which could cause the trigger daemon to poll too often
ClosedPublic
Actions

Authored by epriestley on Mar 11 2016, 11:47 PM.

Tags

None

Referenced Files

	F14729455: D15464.diff
	Sat, Jan 18, 6:46 AM

	F14723088: D15464.id37267.diff
	Sat, Jan 18, 12:04 AM

	Unknown Object (File)
	Mon, Dec 30, 2:38 AM

	Unknown Object (File)
	Dec 18 2024, 6:22 AM

	Unknown Object (File)
	Dec 12 2024, 11:41 AM

	Unknown Object (File)
	Dec 12 2024, 1:08 AM

	Unknown Object (File)
	Dec 6 2024, 5:04 AM

	Unknown Object (File)
	Nov 29 2024, 6:03 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10537: Nuance Infrastructure

Commits

Restricted Diffusion Commit
rPde23ba0002f8: Fix a minor issue in Nuance which could cause the trigger daemon to poll too…

Summary

Ref T10537. Currently, when you have at least two cursors, the daemon can poll too frequently when processing the last source because it never hits the end-of-list condition.

Test Plan

Ran bin/phd debug trigger.
Observed huge volumes of output before change as triggers fired as fast as possible.
Observed reasonable poll frequency after change.

Diff Detail

Repository

Branch

trigger1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11130
Build 13791: Run Core Tests
Build 13790: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37267.Mar 11 2016, 11:47 PM

epriestley retitled this revision from to Fix a minor issue in Nuance which could cause the trigger daemon to poll too often.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10537: Nuance Infrastructure.

Herald edited edge metadata. · View Herald TranscriptMar 11 2016, 11:47 PM

chad accepted this revision.Mar 12 2016, 12:05 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 12 2016, 12:05 AM

Closed by commit rPde23ba0002f8: Fix a minor issue in Nuance which could cause the trigger daemon to poll too… (authored by epriestley, committed by epriestley). · Explain WhyMar 12 2016, 1:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

workers/

PhabricatorTriggerDaemon.php

2 lines

Diff 37267

src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php

Loading...