Page MenuHomePhabricator

Add a task count to workboards
ClosedPublic

Authored by epriestley on Mar 11 2016, 2:55 AM.
Tags
None
Referenced Files
F13274405: D15462.diff
Fri, May 31, 3:39 AM
F13260449: D15462.diff
Sun, May 26, 11:55 PM
F13247010: D15462.id37265.diff
Thu, May 23, 2:46 PM
F13247009: D15462.id37263.diff
Thu, May 23, 2:46 PM
F13242831: D15462.diff
Thu, May 23, 3:08 AM
F13221266: D15462.diff
Sun, May 19, 2:24 AM
F13217681: D15462.id37265.diff
Sat, May 18, 7:04 AM
F13211609: D15462.id37266.diff
Fri, May 17, 5:55 AM
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP5df5f3390962: Add a task count to workboards
Summary

See Q335. This might need some tweaking, but the JS works now so we can move/style the node now.

Test Plan

Screen Shot 2016-03-10 at 6.54.03 PM.png (1×2 px, 231 KB)

  • Also dragged stuff around, saw counts update properly.

Diff Detail

Repository
rP Phabricator
Branch
workhead
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11128
Build 13788: Run Core Tests
Build 13787: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Add a task count to workboards.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

This isn't quite right because we'll get doubles if points are disabled, but maybe we want to kick the design around a bit first. I'll clean things up so we don't have any redundant stuff left before moving this forward.

We could try [ 123 · 42 ] in the tag itself, per Q335#2540. If we do [ T / P ] with a slash it's ambiguous because we already show [ 30 / 50 ] if there's a point limit on the column, but we can pick some other separator character easily enough.

Here's a [ T · P / L ] version if that looks better?

Screen Shot 2016-03-10 at 7.04.05 PM.png (1×1 px, 222 KB)

I do sort of like putting the count in the tag, but the "·" feels a little weird. Here's a super cool arrow instead:

Screen Shot 2016-03-10 at 7.09.33 PM.png (107×470 px, 8 KB)

chad edited edge metadata.
This revision is now accepted and ready to land.Mar 11 2016, 4:15 AM

I can fiddle it if I get any better ideas.

epriestley edited edge metadata.
  • Use an animated snowman as a divider instead.
This revision was automatically updated to reflect the committed changes.