Page MenuHomePhabricator

Add a task count to workboards
ClosedPublic

Authored by epriestley on Mar 11 2016, 2:55 AM.
Tags
None
Referenced Files
F15461675: D15462.id37266.diff
Tue, Apr 1, 10:16 AM
F15460588: D15462.id37265.diff
Tue, Apr 1, 12:12 AM
F15459001: D15462.id.diff
Mon, Mar 31, 9:03 AM
F15458935: D15462.id37263.diff
Mon, Mar 31, 8:26 AM
F15457078: D15462.diff
Sun, Mar 30, 2:13 PM
F15433002: D15462.id37265.diff
Mon, Mar 24, 8:49 PM
F15412911: D15462.diff
Wed, Mar 19, 3:44 PM
F15384601: D15462.id37265.diff
Fri, Mar 14, 8:22 PM
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP5df5f3390962: Add a task count to workboards
Summary

See Q335. This might need some tweaking, but the JS works now so we can move/style the node now.

Test Plan

Screen Shot 2016-03-10 at 6.54.03 PM.png (1×2 px, 231 KB)

  • Also dragged stuff around, saw counts update properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a task count to workboards.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

This isn't quite right because we'll get doubles if points are disabled, but maybe we want to kick the design around a bit first. I'll clean things up so we don't have any redundant stuff left before moving this forward.

We could try [ 123 · 42 ] in the tag itself, per Q335#2540. If we do [ T / P ] with a slash it's ambiguous because we already show [ 30 / 50 ] if there's a point limit on the column, but we can pick some other separator character easily enough.

Here's a [ T · P / L ] version if that looks better?

Screen Shot 2016-03-10 at 7.04.05 PM.png (1×1 px, 222 KB)

I do sort of like putting the count in the tag, but the "·" feels a little weird. Here's a super cool arrow instead:

Screen Shot 2016-03-10 at 7.09.33 PM.png (107×470 px, 8 KB)

chad edited edge metadata.
This revision is now accepted and ready to land.Mar 11 2016, 4:15 AM

I can fiddle it if I get any better ideas.

epriestley edited edge metadata.
  • Use an animated snowman as a divider instead.
This revision was automatically updated to reflect the committed changes.