Page MenuHomePhabricator
Differential D15457

Move DifferentialRevisionViewController to newPage()
ClosedPublic
Actions

Authored by epriestley on Mar 10 2016, 9:20 PM.
Tags
None
Referenced Files
F18838506: D15457.id37251.diff
Mon, Oct 27, 11:09 AM
F18806930: D15457.diff
Sat, Oct 18, 10:05 PM
F18779797: D15457.id37252.diff
Sat, Oct 11, 3:27 PM
F18713354: D15457.id.diff
Sep 29 2025, 6:09 AM
F18702779: D15457.diff
Sep 28 2025, 1:31 AM
F18647934: D15457.diff
Sep 19 2025, 3:14 PM
F18227593: D15457.id.diff
Aug 20 2025, 6:30 AM
F18222142: D15457.diff
Aug 19 2025, 8:12 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP7b8da9991429: Move DifferentialRevisionViewController to newPage()
Summary

I think this works?

Test Plan

i am wizard

Screen Shot 2016-03-10 at 1.19.22 PM.png (1×3 px, 389 KB)

Diff Detail

Repository
rP Phabricator
Branch
newpage1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11114
Build 13767: Run Core Tests
Build 13766: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37251.Mar 10 2016, 9:20 PM
epriestley retitled this revision from to Move DifferentialRevisionViewController to newPage().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald edited edge metadata. · View Herald TranscriptMar 10 2016, 9:20 PM
chad added a comment.Mar 10 2016, 9:21 PM

haha, there already was a setNavigation lulz.

epriestley added a comment.Mar 10 2016, 9:21 PM

i am time wizard

chad accepted this revision.Mar 10 2016, 9:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2016, 9:22 PM
Closed by commit rP7b8da9991429: Move DifferentialRevisionViewController to newPage() (authored by epriestley, committed by epriestley). · Explain WhyMar 10 2016, 9:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
22 lines

Diff 37251

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
Phabricator · Built by Phacility