Differential D15454

Use more explicit language for unassigning tasks
ClosedPublic
Actions

Authored by epriestley on Mar 10 2016, 2:48 AM.

Details

Reviewers

chad

Maniphest Tasks

T10493: Task creation no longer lists projects added (neither the UI nor mail notifications)

Commits

Restricted Diffusion Commit
rP99bc1b05d701: Use more explicit language for unassigning tasks

Summary

Ref T10493.

Call this action "Unassigned" instead of "Up For Grabs", since the latter implies that it's OK for anyone to grab it, which is a social/context thing that we probably shouldn't assume.
Show who a task was previously assigned to in the transaction.

The text is a little clunky, yell if you've got a better wording? Or maybe I'll come up with something.

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

upfor1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11107
Build 13756: Run Core Tests
Build 13755: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37244.Mar 10 2016, 2:48 AM

epriestley retitled this revision from to Use more explicit language for unassigning tasks.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

epriestley mentioned this in T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).Mar 10 2016, 2:49 AM

chad accepted this revision.Mar 10 2016, 2:50 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 10 2016, 2:50 AM

Some alternate, equally clunky wordings:

cat unassigned dog from this task.
cat unassigned this task, evicting dog from the seat of power.
cat reassigned this task from dog to no one.
cat unassigned this task, which was previously assigned to dog.

I'm still thinking about it

this is pretty important

what if I get it wrong and everyone laughs at me?

cat unassigned this task, evicting dog from the seat of power.

Closed by commit rP99bc1b05d701: Use more explicit language for unassigning tasks (authored by epriestley, committed by epriestley). · Explain WhyMar 11 2016, 1:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

storage/

ManiphestTransaction.php

7 lines

Diff 37244

View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Use more explicit language for unassigning tasksClosedPublicActions