Page MenuHomePhabricator

Begin adding test coverage to GitHub Events API parsers
ClosedPublic

Authored by epriestley on Mar 9 2016, 3:35 PM.

Details

Summary

Ref T10538.

This is a tiny fraction of the API. GitHub has 25 primary event types; we currently partially parse 3 of them. GitHub has 17 issue event types; we currently partially parse 12.

Test Plan

Ran arc unit.

Diff Detail

Repository
rP Phabricator
Branch
nuance16
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/nuance/github/NuanceGitHubRawEvent.php:46XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 11092
Build 13736: Run Core Tests
Build 13735: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Begin adding test coverage to GitHub Events API parsers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

itsawesome

This revision is now accepted and ready to land.Mar 9 2016, 4:28 PM
This revision was automatically updated to reflect the committed changes.