Is this what you mean?
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T8941: Badges don't show in certain Timeline conditions
Before:
After:
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- beneath
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 11083 Build 13720: Run Core Tests Build 13719: Run Core Tests Build 13718: arc lint + arc unit
Event Timeline
Comment Actions
From a pure "empathy" viewpoint we could also rename "Invalid" to "Support Not Available From Upstream" and "Wontfix" to "Not On Upstream Roadmap" or something, but the users I can recall taking offense to this stuff have sort of seemed a little unstable anyway.
I don't think these terms (or "Fishing Expedition", for that matter) are un-empathetic for anyone in a wide radius of our target audience.
Comment Actions
Regretfully Our Meager Skills Are Insufficient To Tackle This Noble Challenge
An Excellent Idea Which We Lack the Conviction or Strength of Character to Pursue, O Woe
Comment Actions
This code is kind of funky and probably overdue for a rewrite (e.g., to fix T8941) so yell if you get stuck somewhere in the five different pieces of code that group or reorder things. It took me a couple of tries to come up with this patch, and I think I wrote the surrounding code.