Page MenuHomePhabricator

Add Nuance daemons and item types
ClosedPublic

Authored by epriestley on Mar 8 2016, 9:40 PM.
Tags
None
Referenced Files
F14830560: D15441.diff
Wed, Jan 29, 9:29 PM
Unknown Object (File)
Sat, Jan 25, 9:33 PM
Unknown Object (File)
Fri, Jan 24, 4:43 PM
Unknown Object (File)
Fri, Jan 24, 12:12 PM
Unknown Object (File)
Fri, Jan 24, 12:12 PM
Unknown Object (File)
Fri, Jan 24, 12:12 PM
Unknown Object (File)
Tue, Jan 21, 10:35 AM
Unknown Object (File)
Mon, Jan 13, 1:00 AM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10537: Nuance Infrastructure
Commits
Restricted Diffusion Commit
rPe5f867e0df34: Add Nuance daemons and item types
Summary

Ref T10537. This adds an update daemon for pulling item data (e.g., figuring out who the author of a GitHub comment is) and routing items (e.g., sending them to a queue or applying them directly to a task).

Also adds bin/nuance update --item X for doing this manually for debugging.

And adds item types, for specializing item behavior. Previously, sources completely dictated item behavior, but I think we want something a little more flexible.

Test Plan
  • This still does nothing.
  • Ran bin/nuance update --item 15.
  • Saw an item route to a default queue.

Diff Detail

Repository
rP Phabricator
Branch
nuance11
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/nuance/item/NuanceGitHubEventItemType.php:13XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 11079
Build 13711: Run Core Tests
Build 13710: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Add Nuance daemons and item types.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2016, 2:16 AM
This revision was automatically updated to reflect the committed changes.