Differential D15438

Add a GitHub API Future
ClosedPublic
Actions

Authored by epriestley on Mar 8 2016, 4:29 PM.

Details

Reviewers

chad

Maniphest Tasks

T10538: Bridge GitHub to Phabricator

Commits

rPHU7e2eca1f76d1: Add a GitHub API Future

Summary

Ref T10538. See next change for usage.

Test Plan

See next change.

Diff Detail

Repository

rPHU libphutil

Branch

github1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11069
Build 13699: Run Core Tests
Build 13698: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37204.Mar 8 2016, 4:29 PM

epriestley retitled this revision from to Add a GitHub API Future.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10538: Bridge GitHub to Phabricator.

chad accepted this revision.Mar 8 2016, 5:10 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 8 2016, 5:10 PM

Minor fixes for rate limit / not modified detection.

Closed by commit rPHU7e2eca1f76d1: Add a GitHub API Future (authored by epriestley, committed by epriestley). · Explain WhyMar 8 2016, 6:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

future/

github/

PhutilGitHubFuture.php

130 lines

PhutilGitHubResponse.php

49 lines

Diff 37207

View Options

src/__phutil_library_map__.php

View Options

src/future/github/PhutilGitHubFuture.php

View Options

src/future/github/PhutilGitHubResponse.php

Add a GitHub API FutureClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37207

src/__phutil_library_map__.php

src/future/github/PhutilGitHubFuture.php

src/future/github/PhutilGitHubResponse.php

Add a GitHub API Future
ClosedPublic
Actions

Revision Contents
Changeset List